Uppy: Thumbnail previews are lost after Browser Refresh

[dviry]

Not sure if this is specifically related to the "Golden-Retriever" plugin, but in Chrome@Win after refreshing the page (with queued not-uploaded files) the preview are lost (and show the ugly NotFound Image). Those "blob://..." urls are basically invalid - according to the docs the browser is not supposed to keep them.

1. if a preview cannot be found/done it should show the "default" thumbnail (instead of Chrome's NotFound image) - even when recovering files
2. I don't understand why those previews are either:
   A: re-created since the File contents are saved in IndexedDB -> personally preferred (saves diskspace)
   or B: also saved in the IndexedDB next to the contents

I am getting the same results when using the Golden-Retriever ServiceWorker, but I haven't debugged this further - just wondering if you aware of this as in one of your blog articles you mentioned you are working on improving it (files that cannot be uploaded, invalid thumbnails, etc...) - yet I am not aware of any releases (and that special Branch also seems gone)

Thanks in advance,
Leon

[goto-bus-stop]

Unfortunately we haven't gotten to some of the fancy features that we were hoping to implement for Golden Retriever yet, after all this time :(

I believe thumbnails are supposed to regenerate after a refresh, like your 2A point. It's definitely a bug that they don't. Possibly thumbnail-generator needs to listen for the 'restore' event and kick off generation again for blob URLs.

[dviry]

Oh so you mean the issue is maybe in the thumbnail-generator Plugin? I'll have a look in there...

I really like uppy and the combination with Golden-Retriever's resuming capabilities is really something else - since I am using it in a ReactJs Application (which is sometimes offline) I might work on improvements and submit some PRs, when I get around to finishing my other stuff first ;)

Do you know if I can get my hands on the code for the screens shown in #257 ? Since the branch "feature/restore-files" does not seem to exist anymore and I haven't seen those merged back to master...

Thanks

[arturi]

The “restore prompt” shown in those screenshots has never actually been implemented, it was my task, and still on my todo list. Sorry about that.

[dviry]

OK - was able to find the issue - timing/order issue when using the Dashboard component, since it registers the Thumbnail-generator only AFTER actually running the Golden-retriever, so obviously the Restore event was never caught... I am now doing .use(GoldenRetriever) only after the Dashboard actually loaded.

Thanks