Universalmediaserver: Refactor "RequestV2" class

[drakulis]

Current state
RequestV2 class is insanely long and its main method (answer) has ~1000 lines of code with massive amount of if / else statements. It is highly unreadable and hard to debug such method

Todo

• extract if / else blocks into separate methods
• create common method for creation of response payload to avoid adding XML_HEADER, SOAP_ENCODING_HEADER and SOAP_ENCODING_FOOTER over and over again

Goal
Improve readability and debugging of the class.

@SubJunk I can take care of it. Are you interested with such contribution? If not just close this issue.

[valib]

@drakulis it seems promising. Just do it. 👍

[valib]

@SubJunk in the end I think that is time to decide if the UMS will use the old implementation or the Netty which is set as default and not confuse users with those two options.

[SubJunk]

@drakulis yes this is a good idea

@valib yes let's at least remove the old one from the GUI, if not remove it entirely

[drakulis]

OK, so refactoring such big class will be a challenge and it will be very easy to break something during this process. Additionally reviewing the changes in PR would be a nightmare.

So I will do it in few steps and create PR when I finish each of them. Currently I see following:

• extract common createResponse method to avoid adding XML_HEADER, SOAP_ENCODING_HEADER and SOAP_ENCODING_FOOTER over and over again
• extract searchHandler method
• extract other easy to extract handlers like imageResourceHandler, mediaReceiverRegistrarHandler, getSystemUpdateIdHandler and others
• extract fileHandler (movie, music etc). This one will be tricky.
• ...
• extract service handlers (ContentDirectoryHandler, ConnectionManagerHandler etc)

All the changes above will be done in the RequestV2 class. After that we may think about extracting separate, single responsibility classes from it.

[SubJunk]

Yes I really like having small pull requests for reviews, it keeps it moving along much faster and safer

[SubJunk]

@drakulis are you just taking a break or is this abandoned? I'm happy to leave it open if you're taking a break, no rush :)

[drakulis]

@SubJunk just a break. I have tough project right now and I have to focus on it completely.

[SubJunk]

Cool, no problem. See you when you get back :)