Umbraco-cms: Blocklist doesn't save on first attempt

[AaronSadlerUK]

I have blocklist setup in inline mode.

If I add a block and enter my content, it will not save, the postsave request contains an empty value:

{"id":2250,"alias":"leftColumnContent","value":""}

If I then refresh the page, and then carry out the exact same as above, it will save the content.

This happens on both v8.8.0 and v8.8.1

---

_This item has been added to our backlog AB#9258_

[nathanwoulfe]

Hi @AaronSadlerUK I was able to reproduce this:

• delete existing blocks
• save and publish
• DO NOT REFRESH
• add new block
• save (posted data matches your example)
• refresh
• no block
• add new block
• save
• refresh
• block exists

Will throw it open for anyone interested in diving deeper...

[umbrabot]

Hi @AaronSadlerUK,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

[AaronSadlerUK]

Sorry to be a pain @nathanwoulfe, but surely with a bug as critical as this one, it should be fixed by HQ.

This is a real issue when creating new nodes, as the editor may not know to refresh the page to make it work.
And the fact it's pretty much useless on creation of the node.

Unfortunately I do not know enough angular to even consider fixing this.

[nul800sebastiaan]

I hadn't gotten around to replying to this one yet, but that's correct, regression bugs should be fixed by HQ. We've got it, thanks!

[nul800sebastiaan]

@AaronSadlerUK I have a build ready and I THINK it fixes the issue but I would love it if you could try it out (only the dlls is what you'll need to test with if you would like to try it on your existing site).

[nul800sebastiaan]

Oh oops, link: https://dev.azure.com/umbraco/Umbraco%20Cms/_build/results?buildId=51232&view=artifacts&type=publishedArtifacts

[AaronSadlerUK]

Ok great, I will check this shortly :)

[nul800sebastiaan]

Ah of course! Hmm, try this one, they're built as 8.8.1 without the alpha: https://wetransfer.com/downloads/c58acceb9fff2119c64054d3ca01b01220201104093016/c0a8d797603b79d1689384d612878d8820201104093031/af8727

[AaronSadlerUK]

Ok so the issue still persists, I think this is more angular than DLL side?

The steps are:

• Create a new node only thing I am setting is the name, click Save and Publish
• 
  
  
  
  • Then add a blocklist editor block and click save and publish.
  
  
• 
  
  
  
  • The block does not get saved.
  
  

{"id":1952,"contentTypeAlias":"content","parentId":1073,"action":"publish","variants":[{"name":"Test page 4","properties":[{"id":0,"alias":"keywords","value":[]},{"id":0,"alias":"description","value":""},{"id":0,"alias":"socialShareImage","value":""},{"id":0,"alias":"headerBlock","value":""},{"id":0,"alias":"contentBlocks","value":""},{"id":0,"alias":"leftColumnContent","value":""},{"id":0,"alias":"masonryBlocks","value":""},{"id":0,"alias":"umbracoRedirect","value":""},{"id":0,"alias":"umbracoInternalRedirectId","value":""},{"id":0,"alias":"umbracoUrlName","value":""},{"id":0,"alias":"umbracoUrlAlias","value":""},{"id":0,"alias":"sitemapExclude","value":"0"}],"culture":null,"segment":null,"publish":true,"save":true,"releaseDate":null,"expireDate":null}],"expireDate":null,"releaseDate":null,"templateAlias":"Content"}

[nul800sebastiaan]

What am I doing differently?

Part of what's being posted:

{"Umbraco.BlockList":[{"contentUdi":"umb://element/e370e5235e0c4a8cac866ee628468a9f"}]},"contentData":[{"contentTypeKey":"0e1d4bd4-ae9f-4b93-a875-b5d70447b89a","udi":"umb://element/e370e5235e0c4a8cac866ee628468a9f","featureName":"test","featureDetails":""}],"settingsData":[]},"alias":"try","editor":"Umbraco.BlockList","isSensitive":false,"culture":null,"segment":null}]}

[AaronSadlerUK]

Your doing the same as me.

Happy to jump on a Zoom call if easier?

Or I could package up the site as I currently have it?

[nul800sebastiaan]

I am swamped for the rest of the morning/early afternoon but happy to look at your site if you can send it over, email might be best (sj at umbraco do t dk)

[AaronSadlerUK]

Ok great I have sent it via WeTransfer

If you install the site into a clean DB and then use the uSync import it will add the content.

Create a new node of content under home to test.

[nul800sebastiaan]

Exciting, I will need to learn uSync! 😅

[AaronSadlerUK]

It's easy...

Settings -> uSync -> Import

Then Ctrl + F5 the backoffice and the content should appear

[nathanwoulfe]

I'm spinning up a clean 8.8.1, will drop in the updated dlls and see what happens...

[nathanwoulfe]

Issue persists in the new build. This was a brand new node, added block content, saved - no value posted (see below, variants[0].tabs[0].properties[0].value === '' but should be a JSON object). If I refresh the backoffice, add content and save/publish, works fine.

[nul800sebastiaan]

Got it, I have a repro now as well! Will send it on to the team! 👍

[nul800sebastiaan]

[nathanwoulfe]

I can't reproduce on latest from v8/contrib, so maybe has been resolved as part of other changes...

[nul800sebastiaan]

Oh.. that's interesting! I'll test check as well! 👍

[nul800sebastiaan]

Aha.. I think it's this one! https://github.com/umbraco/Umbraco-CMS/pull/9215 Testing that theory now...

[nul800sebastiaan]

Works for me!

If you want to try it locally, update Umbraco\Js\umbraco.directives.js, the function on line 18809 (onServerValueChanged) should read:

            function onServerValueChanged(newVal, oldVal) {
                // We need to ensure that the property model value is an object, this is needed for modelObject to recive a reference and keep that updated.
                if (_typeof(newVal) !== 'object' || newVal === null) {
                    // testing if we have null or undefined value or if the value is set to another type than Object.
                    vm.model.value = newVal = {};
                }
                modelObject.update(vm.model.value, $scope);
                onLoaded();
            }

Make sure to update the version in ClientDependency.config after you do that and you probably need to do a hard browser refresh just to make sure the changes kicked in.

This change is already part of the upcoming release 8.8.2 and higher which we hope to release next week, so I'll close this for now. 👍