Umbraco-cms: Remove konamiCode directive

[bjarnef]

Previous a Konami Code directive was added, which was used in login screen:
https://github.com/umbraco/Umbraco-CMS/commit/110d54c4b889d7b1f764988376983e841e5d2fcb#diff-dc33660b110ebb44336122f82b7fdb7f

The directive still exists here, but it isn't used anywhere.
https://github.com/umbraco/Umbraco-CMS/blob/v8/dev/src/Umbraco.Web.UI.Client/src/common/directives/util/konami.directive.js

The old login screen view, where it was used, was removed here:
https://github.com/umbraco/Umbraco-CMS/commit/10caf7b75bfdf32168a80af051a5657fa258674f#diff-195afef8f203b776fcd3ad8b874d8b09

So should the directive be removed or do we intend to use the Konami Code directive on the new login screen?

[nul800sebastiaan]

👍 go for it!

[umbrabot]

Hi @bjarnef,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

[bjarnef]

@nul800sebastiaan so we should remove the directive?

[nul800sebastiaan]

That's what the title of the issue says ;-)

[bjarnef]

@nul800sebastiaan yes, since it isn't used, but I wasn't sure if it is a mistake that the konami code wasn't added to the newer login view?

[nul800sebastiaan]

Please remove it, like you suggested.

[nathanwoulfe]

This is a sad day.

[kjac]

Indeed a sad, sad day @nathanwoulfe 😆

Fixed in #7437