Umbraco-cms: Multi node tree picker (MNTP) start node always seems to be default language - not variant aware

[DanDiplo]

Context: a multilingual Umbraco 8.4.0 site with multiple languages. When I set the start node for a MNTP it always shows the nodes for the default culture, even when editing content in a different culture. So if I am editing content with German culture then the MNTP shows the nodes as if I were viewing them as the default culture (en-US).

Umbraco version

I am seeing this issue on Umbraco version: 8.4.0

Reproduction

Bug summary

MNTP doesn't respect current editor culture.

Specifics

MNTP lets you pick nodes that aren't published in the editor culture you are using.

Steps to reproduce

• Create a site with multiple language cultures and set "en-US" as default language.
• Create a document type with "Allow varying by culture" enabled
• Create a property that can also be varied by culture and use the MNTP as the property editor
• Set the MNTP start node to a listing page
• On that listing page create some child nodes that vary by culture. Publish some of these nodes in the default language and some in, say, "de-DE" culture. Just ensure the DE tree is different to the US tree.
• As an editor set the tree to DE and then go to the page with the MNTP. It will show a list of pages from the US tree, rather than the DE tree. It will show as published nodes that aren't published in the DE language, which are selectable. (If you try and access these nodes in code they have a URL set to "#")

Note: This happens if you set the start node by picking it _and_ also if you use XPath to set it. The result is the same.

Expected result

I'd expect the MNTP to show me the DE version of the tree when editing in DE, with any nodes that are not published in DE greyed-out and unselectable.

Actual result

You see the US tree. This lets you select nodes that are not published in DE (and also greys out nodes that are published in DE but not in US).

Screenshots

German tree for "Kunder" (Customers) as seen in the content tree view:

The view the MNTP shows when editing using DE culture. Note it doesn't show the same view. The nodes "Practicus", "Advantage Solutions" and "Balfour Beatty" are not published in DE version, yet are shown as published and selectable.

Here is the US tree view for "Customers". You can see the MNTP is showing this view, even when editing in DE.

[nul800sebastiaan]

Thanks @DanDiplo for the detailed report. Work on this is in progress, make sure to monitor the progress of #7114

[DanDiplo]

Hi @nul800sebastiaan I searched open issues and couldn't find any similar issue. I hadn't realised an open issue would be closed. It would maybe save people wasting time reporting duplicate issues if you only closed an issue once it was released? Cheers.

[nul800sebastiaan]

I know how annoying it is to learn that to the best of your search abilities you couldn't find anything. Not much we can do about that since we don't control the search features on GitHub.

We don't want to have multiple issues for the same thing open, so duplicates are getting closed so that we can track 1 issue for 1 bug/feature request. Having multiple issues open for the same request has in the past always led to 3 issues being closed and the 4th open issue being forgotten, only to realize much later that the issue had been resolved already.

I will add "MNTP" as a keyword to #7114 though, since it seems that was missing and why you didn't find that issue in the first place.

[nul800sebastiaan]

Ah hang on, I got myself confused here. That other issue is for the Multi URL Picker. I'll reopen this as a separate issue.

[kjac]

I'll dig into this later today to see if I can repro on vLatest 👍

[kjac]

Yeah so this is definitely an issue. It also has an element of timing, as client execution time may or may not cause this to happen.

I have tracked down the culprit, will have a look at fixing it today.

[kjac]

PR in #7325

[poornimanayar]

PR in #7325