Umbraco-cms: Sticky header shows in "scrolled down" state before scrolling
A lot of the time I see the sticky header in its "scrolled down" state even if I haven't started scrolling yet:
It happens on load. If I scroll down and up again, the "scrolled down" state disappears.
kjac
All 5 comments
By the looks of it this is caused by the changes introduced by 68656290. Simplest way to reproduce is to open the groups list and reload it until the problem manifests:
From what I can gather it happens when observeFooter fires after observeHeader.
/cc @nathanwoulfe
kjac
on 15 Jul 2019
Yup that would be it - thought I'd resolved that... I think it's happening when the observer fires before the content has fully loaded, so the injected sentinel element is higher in the viewport and triggers the active state.
I'll fix this today, just needs a flag set when the header interceptor fires, to check when running the footer, I think. Will sort it out regardless.
nathanwoulfe
on 15 Jul 2019
Thanks mate. It's been doing my head in 馃榾
kjac
on 16 Jul 2019
Likewise. There are a few different places using the umb-sticky-bar directive, and all are slightly different contexts so behave slightly differently. Pretty sure I have it sorted now, but have another PR with pending changes that I'd like to pull down first to verify it all plays nice.
nathanwoulfe
on 16 Jul 2019
I've closed 5834 because I borked my branch, #5918 now has the fix for this.
nathanwoulfe
on 17 Jul 2019
Related issues
Luksor
路
3Comments
0Neji
路
3Comments
junkin77
路
3Comments
callumbwhyte
路
3Comments
PullensDennis
路
3Comments
Most helpful comment
Likewise. There are a few different places using the umb-sticky-bar directive, and all are slightly different contexts so behave slightly differently. Pretty sure I have it sorted now, but have another PR with pending changes that I'd like to pull down first to verify it all plays nice.