Twindle: Enabling required reviews for pull requests

[arthurbuhl]

Enabling required reviews for pull requests

Overview

Repository administrators can enforce required reviews so that pull requests must have a specific number of approving reviews before they are merged. This will help in better coordination and making sure only valid reviewed PRs are only merged.

For more info: Enabling required reviews for pull requests

Status

_Open For Discussion_

[johnjacobkenny]

Sounds good! @proful @sarathkumar6

[proful]

Can you @johnjacobkenny enforce 2 reviewer please?

Anyone should able to review and approve.

[johnjacobkenny]

@proful I can't see the option mentioned in the link. Maybe access is restricted. Please take a look

[proful]

I have enforced reviews @johnjacobkenny @arthurbuhl

Watch out for any issues

[johnjacobkenny]

Yes it is working @proful. The reviewers though are only the people with write access. Might be a bottleneck with just us 3.

[proful]

I thought anyone. Not?

Can you ask someone else to check

[arthurbuhl]

This doesn't seem to be working properly. Me & @PrasoonPratham approved #190, but its still saying

At least 2 approving reviews are required by reviewers with write access. 

[proful]

Yes any solution?

[arthurbuhl]

I think we need to look into Repository permission levels for an organization and upgrade few members to Team Maintainer or Collaborators roles.

[johnjacobkenny]

@proful please take a look

[proful]

Thanks @arthurbuhl I read the organization. Looks good I will try it.

[piratelicorne]

🏆

[proful]

The manual process is good enough

in the future, it can be re-opened.

Now cleaning up issues.