Triplea: New Battle calc: Retreat after round: 1

[ZjelcoP]

Battle calc fixes and improvements #4576

1.10.14134

Windows 7

WAW

Make a calculation, select retreat after round: 1

No Error, Average attackers units left is calculated for multiple battle rounds (go for the win)
Had this occur at least twice during game. Can reproduce, but not for every battle....

Also easily calculated battles do not produce exact numbers.....?

[ron-murhammer]

@ZjelcoP Looks like there might be an issue around thinking air units are dead when retreating after round. Is the second screenshot with dice or LL? For dice it is always going to be an approximation so that looks about right.

[ZjelcoP]

It's LL.

[ron-murhammer]

@ZjelcoP I tried reproducing the second battle with the latest pre-release and get the correct result:

I think you must have had dice instead of LL on.

The first one does seem to be an issue and I was able to reproduce it.

[ZjelcoP]

Ah yes, probably had dice on by mistake when testing the issue in revised map :-)

[ron-murhammer]

@ZjelcoP Should be fixed in the pre-release once this PR is merged: https://github.com/triplea-game/triplea/pull/4711