Triplea: 6157 - Missing step name pop-up in combat
Got a pop-up while clicking through on a battle.
Aug 15, 2017 12:32:01 PM games.strategy.triplea.ui.BattleStepsPanel setStep
INFO: Could not find step name:British withdraw?
Looks like if you fight the battle, then the 'info' line pops up. Not sure why I saw it as a pop-up, opening the error console and then opening this save game and proceeding to battle should repro:
info_error.zip
DanVanAtta
All 6 comments
Is the bug that the step name is missing or that the console popped up?
If the latter, #1950 already covers that issue. Basically, anything going through a Logger, regardless of severity, will trigger the console because the default-configured ConsoleHandler sends all output to stderr.
ssoloff
on 15 Aug 2017
Former, the info message is not expected.
DanVanAtta
on 15 Aug 2017
@DanVanAtta @ssoloff This is closely related to the issues that I fixed in #1954. It has to do with the steps are all displayed in the battle window at the start of the round. Depending on casualties some of the withdraw options can change (think amphib units exist at beginning of the round but are all killed off during round so retreat option changes). I simplified the code to show a generic retreat option to avoid the changing retreat types. I guess there are still potential issues here though.
ron-murhammer
on 16 Aug 2017
Excellent! This was one of the ones which I found annoying.
simon33-2
on 21 Sep 2017
This is fixed in #1981.
Please close.
simon33-2
on 22 Oct 2017
Closing per @simon33-2's confirmation. @DanVanAtta, please reopen if there was something else you wanted fixed with this issue.
ssoloff
on 23 Oct 2017
Related issues
panther2
路
6Comments
General-Dru-Zod
路
5Comments
panther2
路
3Comments
DanVanAtta
路
5Comments
Cernelius
路
8Comments
Most helpful comment
@DanVanAtta @ssoloff This is closely related to the issues that I fixed in #1954. It has to do with the steps are all displayed in the battle window at the start of the round. Depending on casualties some of the withdraw options can change (think amphib units exist at beginning of the round but are all killed off during round so retreat option changes). I simplified the code to show a generic retreat option to avoid the changing retreat types. I guess there are still potential issues here though.