Trinitycore: [3.3.5] Voice Chat Service InGame

[duhow]

Reopening of #4241. Could it be possible to do the Voice Chat InGame?

[DDuarte]

What would be required on Trinity to make voice chat work?
Is the protocol used known?
Does it need to be reverse engineered?
What packets are involved?
Did any other project publically available implement voice chat?

[Shauren]

Not known, needs reversing, noone ever uses it on retail anyway because the quality is garbage

[duhow]

Actually, I don't have any idea of how it works, I just know that the option is available...
Maybe it uses another port for communicating.

[Goatform]

As @Shauren already said. It's not used on retail because of bad sound quality. So I don't get why would we need to implement something what's unuseful but yes, I agree that is really nice feature.

[duhow]

Anyway, it could be interesting to inspect it, maybe we can use some kind of "audio codec" to improve it or anything else...

[lorac2k14]

See if you can find the last working (true) Ascent core, it had the voice working. It would be a good starting point to look at the source and see how they were doing it. As for quality and not using it in retail, funny you say no one uses it. My guild actually uses it for guild meetings and it is not that bad. I guess you haven't used it in a while. I for one would find it to be a nice addition to trinitycore. From what I can see it hooks onto port 3725 and uses that port for coms for client. it shouldn't be that hard to convert it for trinitycore once we look it over. It is like 4 .cpp and 2 headers if I remember correctly. If you are interested, I will see if i can find the drive I have the code on.

[HelloKitty]

@lorac2k14 Are you able to provide a link to a working Ascent repo with implemented voice chat? I'm interested in this feature and feel that if the following two things are true.

1. It connects to a different port than the worldserver.
2. It can be hijacked to implement proximity chat.

Then it is of high value to any server looking to increase functionality. Although it wouldn't be blizzlike.

If anyone has data, knowledge of information on this feature please post it. If it connects to a separate port it can be worked on standalone which would be dandy.

[DDuarte]

14:49:07 N@Hellokitty_, ascent had some implementations. Beware its really crappy code: https://github.com/SkyFire/ascent_classic/tree/master/src/ascent-voicechat But maybe it helps you :)

[lorac2k14]

@HelloKitty
Proximity chat uses the same port as battlenet authentication Wont this pose issues with our bnet communication with world server in the current design of bnet?

Sorry it has taken so long to reply rl has been a bit crazy.
But yes I agree it could be a high value not to mention something we can expand our learning on how it works :-)
Oh wait i just noticed 3.3.5 Strike that about using bnet
In current server it does i cant say about 3.3.5a

[Stanwarr]

@HelloKitty maybe work on this if you're interrested?

[FALL1N1]

I've managed to 'partially code' it but I'm not sure how to handle the voice communication between players. Overall everything 'works', they can create channels, join/leave, mute players, mute groups and enable/disable the voice system. Code is total mess, someone might have to rewrite it because it's for older trinity (the azerothcore fork) and the structures are not with the trinity standards for sure. There are couple more opcodes that I'm still working on. I'm open for any ideas on how to handle the communication, after I'm done with it I'll do a PR / paste patch here.
Regards.

here are some screenshots
http://prntscr.com/j8acpb
http://prntscr.com/j8ad0o
http://prntscr.com/j8adl4 - minimal button (channel join/leave)