Trinitycore: DB/Quest: That's What Friends Are For...

[dr-j]

https://www.wowhead.com/quest=12903/thats-what-friends-are-for
https://www.wowhead.com/quest=12003/uncovering-the-tunnels

Currently the 3 npcs which the player has to discover to complete this quest all give kill credit via ooc los (SAI event 10) because of discovering a issue with burr giving credit due to feign death I decided to investigate this further and found that there is areatrigger by all 3 npcs which must be discovered for this quest.

Below rescripts this quest to use areatriggers for kill credits instead of using ooc los on npcs themselves
~~~sql
DELETE FROM areatrigger_scripts WHERE entryIN(5174,5175,5176);
INSERT INTO areatrigger_scripts (entry, ScriptName) VALUES
(5174, 'SmartTrigger'),
(5175, 'SmartTrigger'),
(5176, 'SmartTrigger');

DELETE FROM smart_scripts WHERE entryorguidIN(5174,5175,5176) AND source_type=2;
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, cus_target_param1, comment) VALUES
(5174, 2, 0, 0, 46, 0, 100, 0, 5174, 0, 0, 0, 0, 33, 29455, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (Gerk)'),
(5175, 2, 0, 0, 46, 0, 100, 0, 5175, 0, 0, 0, 0, 33, 29454, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (Burr)'),
(5176, 2, 0, 0, 46, 0, 100, 0, 5176, 0, 0, 0, 0, 33, 29468, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (Crusader Dargoth)');

UPDATE creature_template SET AIName='' WHERE entry IN(29455,29454,29468);

DELETE FROM smart_scripts WHERE entryorguid IN(29455,29454,29468) AND source_type=0;

DELETE FROM areatrigger_scripts WHERE entryIN(4946);
INSERT INTO areatrigger_scripts (entry, ScriptName) VALUES
(4946, 'SmartTrigger'),
(4947 'SmartTrigger'),
(4948, 'SmartTrigger');

DELETE FROM smart_scripts WHERE entryorguidIN(5174,5175,5176) AND source_type=2;
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_param4, target_x, target_y, target_z, target_o, cus_target_param1, comment) VALUES
(4946, 2, 0, 0, 46, 0, 100, 0, 4946, 0, 0, 0, 0, 33, 26468, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (North Building)'),
(4948, 2, 0, 0, 46, 0, 100, 0, 4948, 0, 0, 0, 0, 33, 26469, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (South Building)'),
(4947, 2, 0, 0, 46, 0, 100, 0, 4947, 0, 0, 0, 0, 33, 26470, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Areatrigger - On Trigger - Quest Credit (East Building)');

UPDATE creature_template SET AIName='' WHERE entry IN(26468,26469,26470);

DELETE FROM smart_scripts WHERE entryorguid IN(26468,26469,26470) AND source_type=0;

[github-actions[bot]]

fc856077b5319bc56ab801f9ec4b60050784a298

[offl]

Damn

[offl]

Currently the 3 npcs which the player has to discover to complete this quest all give kill credit via ooc los (SAI event 10) because of discovering a issue with burr giving credit due to feign death

Well, https://github.com/TrinityCore/TrinityCore/issues/25842