Trinitycore: Wintergrasp quests not completed

[digz6666]

Following 8 quests not completed even I do it:

1. Victory in Wintergrasp (horde) - http://www.wowhead.com/quest=13183
2. Victory in Wintergrasp (alliance) - http://www.wowhead.com/quest=13181
3. Stop the Siege (horde) - http://www.wowhead.com/quest=13185
4. Stop the Siege (alliance) - http://www.wowhead.com/quest=13186
5. Defend the Siege (horde) - http://www.wowhead.com/quest=13223
6. Defend the Siege (alliance) - http://www.wowhead.com/quest=13222
7. Toppling the Towers - http://www.wowhead.com/quest=13539
8. Southern Sabotage - http://www.wowhead.com/quest=13538

Source: https://github.com/TrinityCore/TrinityCore/commit/94b2f90a5a821db38cb5c8430bc029423557cd2f
Database: TDB.335.49

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[chaosua]

for 7 and 8

src/server/game/Battlefield/Zones/BattlefieldWG.cpp | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/src/server/game/Battlefield/Zones/BattlefieldWG.cpp b/src/server/game/Battlefield/Zones/BattlefieldWG.cpp
index 2270bcf..f67a458 100644
--- a/src/server/game/Battlefield/Zones/BattlefieldWG.cpp
+++ b/src/server/game/Battlefield/Zones/BattlefieldWG.cpp
@@ -980,8 +980,18 @@ void BattlefieldWG::ProcessEvent(WorldObject *obj, uint32 eventId)
                 (*itr)->Damaged();

             if ((*itr)->m_Build->GetGOInfo()->building.destroyedEvent == eventId)
           {
                 (*itr)->Destroyed();
+
+               // Add Support of Quests Toppling the Towers & Southern Sabotage
+                if (go->GetEntry()==190356 || go->GetEntry()==190357 || go->GetEntry()==190358)
+                {
+                    for (GuidSet::const_iterator itr = m_PlayersInWar[GetDefenderTeam()].begin(); itr != m_PlayersInWar[GetDefenderTeam()].end(); ++itr)
+                        if (Player* player = sObjectAccessor->FindPlayer(*itr))
+                            player->RewardPlayerAndGroupAtEvent(35074, go);
+                }
            }

             break;
         }
     }

[digz6666]

Thanks, I will try today evening and post my results.

[Retriman]

plz test https://gist.github.com/3872919

[Star-lion]

thats not the way to do it.

[digz6666]

@chaosua Its not working because I'm in raid group. It will work if I leave raid group.

[chaosua]

@digz6666 it's works for me.
Try enable in config Quests.IgnoreRaid = 1, but i think it must work without it

[digz6666]

Is there any side effect after enable this?

[chaosua]

Description
Quests.IgnoreRaid
Description: Allow non-raid quests to be completed while in a raid group.
Default: 0 - (Disabled)
1 - (Enabled)
nothing bad ...
or make that quest with raid flags I think it must be with raid flag

[Zedron]

confirmed all of them.

[Kingswow]

Confirmed
f9c193d27d0239d6c63b59adc64bb9f43d58e37e
TDB335.49 + Updates

[ghost]

TrinityCore rev. 7ee5214f7d6a+ 2013-09-20 09:19:15 -0400 (master branch) (Win32, Release)

Confirmed does not work. You get Achievements but no Quest Complete

[Rushor]

I think we need a general flag in 'Flags' in 'quest_template' which allows us to complete quest with a raid and without a raid group.

[SeTM]

https://gist.github.com/SeTM/c7399270ff030515425d

[zgn1988]

Latest rev 3.3.5a
Quest Flags = 32842 =(
32768 QUEST_FLAGS_WEEKLY +
64 QUEST_FLAGS_RAID + // does not work?
8 QUEST_FLAGS_SHARABLE +
2 QUEST_FLAGS_PARTY_ACCEPT)

// Hack
UPTATE quest_template SET =Flags = 32778 WHERE Id IN (13183,13181,13185,13186,13223,13222,13539,13538); // - 64 Flags

[Rushor]

addition:

1. Victory in Wintergrasp (horde) - http://www.wowhead.com/quest=13183
2. Victory in Wintergrasp (alliance) - http://www.wowhead.com/quest=13181

these quests can be accapted mutiple times in a week. you can also complete it mutiple times in a week, but you can only reward it once in a week.

normally you should not be able to accapt the quest mutiple times

[el-druida]

This issue still persists

[Aokromes]

test #17535
Also https://github.com/TrinityCore/TrinityCore/issues/7953#issuecomment-9188296 works if #17535 is applied?

[ghost]

[Core/Quest: implement usage of QUEST_FLAGS_RAID to allow a quest to be completed while in raid] #17535 is now merged into 3.3.5 so you can just update your sources to see if things have improved.

[SnapperRy]

Aaaaand we can finally forget about this :P