Trinitycore: DB/Quest: SAI Quest Credit not cast on player when 'Protect Kaya' ends
Description:
Quest: 'Protect Kaya' does not give Quest Credit from its SAI line 1185602, 9, 3.
- https://classic.wowhead.com/quest=6523/protect-kaya
- https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?quest=6523
- https://classic.wowhead.com/npc=11856/kaya-flathoof
- https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?npc=11856
The quest ends after the scripted attack and the 3 mobs die, she walks a bit further,
says Kaya Flathoof says: Thank you for helping me. I know my way back from here.
and despawns. Nothing more. Neither failed nor completed.
SELECT * FROM `smart_scripts` WHERE `entryorguid` LIKE "11856%" ORDER BY `source_type`, `entryorguid`, `id`;
entryorguid source_type id link event_type event_phase_mask event_chance event_flags event_param1 event_param2 event_param3 event_param4 event_param5 action_type action_param1 action_param2 action_param3 action_param4 action_param5 action_param6 target_type target_param1 target_param2 target_param3 target_param4 target_x target_y target_z target_o comment
----------- ----------- ------ ------ ---------- ---------------- ------------ ----------- ------------ ------------ ------------ ------------ ------------ ----------- ------------- ------------- ------------- ------------- ------------- ------------- ----------- ------------- ------------- ------------- ------------- -------- -------- -------- -------- -------------------------------------------------------------
11856 0 0 0 19 0 100 0 6523 0 0 0 0 80 1185600 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Quest 'Protect Kaya' Taken - Run Script
11856 0 1 0 40 0 100 0 17 0 0 0 0 80 1185601 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Waypoint 17 Reached - Run Script
11856 0 2 0 40 0 100 0 19 0 0 0 0 80 1185602 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Waypoint 19 Reached - Run Script
11856 0 3 0 6 0 100 0 0 0 0 0 0 6 6523 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Death - Fail Quest 'Protect Kaya'
1185600 9 0 0 0 0 100 0 0 0 0 0 0 64 1 0 0 0 0 0 16 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Store Targetlist
1185600 9 1 0 0 0 100 0 0 0 0 0 0 83 2 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Remove NPC Flag Questgiver
1185600 9 2 0 0 0 100 0 0 0 0 0 0 1 0 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Say Line 0
1185600 9 3 0 0 0 100 0 5000 5000 0 0 0 53 0 11856 0 0 0 2 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Start Waypoint
1185600 9 4 0 0 0 100 0 0 0 0 0 0 19 512 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Remove Flag Immune To NPC's
1185600 9 5 0 0 0 100 0 0 0 0 0 0 2 113 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Set Faction 113
1185601 9 0 0 0 0 100 0 0 0 0 0 0 54 7000 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Pause Waypoint
1185601 9 1 0 0 0 100 0 0 0 0 0 0 18 512 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Add Flag Immune To NPC's
1185601 9 2 0 0 0 100 0 2000 2000 0 0 0 107 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Summon Group 0
1185601 9 3 0 0 0 100 0 2000 2000 0 0 0 1 1 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Say Line 1
1185601 9 4 0 0 0 100 0 3000 3000 0 0 0 19 512 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Remove Flag Immune To NPC's
1185602 9 0 0 0 0 100 0 0 0 0 0 0 54 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Pause Waypoint
1185602 9 1 0 0 0 100 0 1000 1000 0 0 0 66 0 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Set Orientation Stored Target 1
1185602 9 2 0 0 0 100 0 0 0 0 0 0 1 2 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Say Line 2
1185602 9 3 0 0 0 100 0 5000 5000 0 0 0 26 6523 0 0 0 0 0 12 1 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Quest Credit 'Protect Kaya'
1185602 9 4 0 0 0 100 0 0 0 0 0 0 41 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 Kaya Flathoof - On Script - Despawn (0)
Expected behaviour:
Kaya Flathoof - On Script - Quest Credit 'Protect Kaya' in row 1185602, 9, 3 should be cast on player.
Steps to reproduce the problem:
- Use a horde player level 15 or higher (able to handle 3 mobs level 17)
.go crea id 11856and take the quest- escort Kaya to the end, kill mobs as you go along.
- follow Kaya a few yards after the scripted attack in Camp Aparaje, until she says her final text.
- Notice that you don't get the quest credit cast on you.
Branch(es):
3.3.5
TC rev. hash/commit:
TrinityCore rev. d0b91f69279a 2020-09-01 22:02:22 +0200 (3.3.5 branch) (Win64, Release, Static)
Using SSL version: OpenSSL 1.1.1g 21 Apr 2020 (library: OpenSSL 1.1.1g 21 Apr 2020)
Using Boost version: 1.73.0
Using MySQL version: 50731
Using CMake version: 3.18.2
Compiled on: Windows 10.0.19041
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 251987687 bytes
vmaps directory located in ./vmaps. Total size: 658130721 bytes
mmaps directory located in ./mmaps. Total size: 3901434544 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.20082
Operating system: Windows 10 Home x64 Version 2004 (OS Build 19041.388)
illfated
All 11 comments
Not sure if it matters that my player is SecurityLevel 3 (GM OFF) or that my character wears gear level ≈ 60 (itemset: Darkmantle Armor). It is more likely that lag caused by game client addons could be negative for testing, but it has not caused server scripts to fail yet (AFAIK).
illfated
on 2 Sep 2020
-- quest 6523 'Protect Kaya' Quest Credit
UPDATE `smart_scripts` SET `action_type` = 15 WHERE `entryorguid` = 1185602 and `source_type` = 9 and `id` = 3;
genion18
on 2 Sep 2020
Wtf, why 26 again
I wonder why I added 26 and why it worked for me or how I didn't noticed it doesn't work
Anyway this is the last with 26
offl
on 2 Sep 2020
is action 26 even needed since 15 with target 16 does group credit
dr-j
on 2 Sep 2020
Going to check if today's commit (https://github.com/TrinityCore/TrinityCore/commit/6e8284a8da0d80391cc0919c32b5ac664be18de2) makes any change related to 26.
illfated
on 2 Sep 2020
Nope, did not help. Looks like we need to replace 26 with 15 here.
illfated
on 2 Sep 2020
I testet 15 in a Group (Prist/Warrior/Druid) and IT's work perfectly.
genion18
on 2 Sep 2020
Thank you for testing that part. I was wondering a little bit about that group detail, but based on what @dr-j said in comment https://github.com/TrinityCore/TrinityCore/issues/25377#issuecomment-685872130 , that makes perfect sense. (my laptop computer does not handle heat well enough to run more than 1 client at a time)
illfated
on 2 Sep 2020
Just to point out a (probably obvious to some) detail, the target_type is 12 ( SMART_TARGET_STORED ) there, but that should make it even more obvious to use action_type 15 in this case (and all other cases like this one).
illfated
on 2 Sep 2020
cosmetic detail for the comment line of the solution provided earlier:
-- quest 6523 'Protect Kaya' Quest Credit
UPDATE `smart_scripts` SET `action_type` = 15 WHERE `entryorguid` = 1185602 and `source_type` = 9 and `id` = 3;
d66263bd76cf20f9e9810d5bd1c01902fd9ad80c
![github-actions[bot] picture](https://avatars.githubusercontent.com/in/15368?v=4&s=40)
github-actions[bot]
on 4 Sep 2020
Related issues
chilito
·
3Comments
DDuarte
·
3Comments
daddycaddy
·
3Comments
funjoker
·
3Comments
ZenoX92
·
3Comments
Most helpful comment