Trinitycore: PvP mode is automatically turned off

[jjo72ddd]

Hello! There is such a problem: if you turn on pvp mode, and a player from the opposite fraction tries to attack you, then he turns on pvp mode for a second and turns off automatically.

Branch(es): 3.3.5
TDB: 335.20021
Ubuntu 18.04
Rev. e7d2489

[jjo72ddd]

I think this is really a big problem.
Video Here

[Rushor]

since what time this is happening?

[jjo72ddd]

since what time this is happening?

it has been (for as long as i can remember) since the server started (about a month ago). It does not depend on the player level.

[jjo72ddd]

but I have an assumption that it depends on the settings of worldserver.conf
Now I have these settings:

SERVER SETTINGS

GameType
    Description: Server realm type.
   Default:     0  - (NORMAL)
                 1  - (PVP)
                 4  - (NORMAL)
                 6  - (RP)
                 8  - (RPPVP)
                16 - (FFA_PVP, Free for all PvP mode like arena PvP in all zones except rest
                      activated places and sanctuaries)

GameType = 0

[Rushor]

what happens if you change it to GameType = 1 ?

[jjo72ddd]

in a couple of minutes I’ll check it and let you know

[jjo72ddd]

still the problem

[Killyana]

This looks weird, the area in the video looks like Elwynn Forest, so why the pvp is not activated automatically for the horde character (if the realm is pvp)

[jjo72ddd]

In my opinion it should be activated pvp automatically when dealing damage regardless of area

[Killyana]

Not in a pvp realm, anyway the issue could be reproduce it in the other sense, with an alliance char (with pvp off) attacking a horde char in an alliance area.

[Thanathros]

Shouldn't we assume pvp as soon as player is in combat with other player ? Attacking automatically enters combat. Correct me on that.

[jjo72ddd]

Shouldn't we assume pvp as soon as player is in combat with other player ? Attacking automatically enters combat. Correct me on that.

as soon as you attack the enemy, your pvp mode should turn on automatically. This is true in the video, but then it turns off automatically

[Killyana]

Not only attacking a player but any action that starts the combat.

[Jildor]

I can confirm.
@Treeston I try to revert this commit: https://github.com/TrinityCore/TrinityCore/commit/671052575a36624b06379ee5e13a7fea26870194
and I can't reproduce the issue without this commit

[Faq]

Solution here https://github.com/Faq/TrinityCore/commit/25f2ae78c62adeb582e7213203d54b09a38a0958

[Killyana]

Please open a PR, to be reviewed.

[jjo72ddd]

Can we close this?
b4584ee
332b2f1

[Killyana]

Need testing

[Killyana]

Not fixed yet https://imgur.com/3Dw0hST

[Faq]

Some things that needs clarification for server realm type NORMAL, correct if I'm wrong.
By correcting me is meant if mentioned result is NOT blizzlike. Personally never played on blizz, so pardon if anything written is wrong.

Horde char in Elwynn forest (unfriendly territory):

1. If "Player vs Player Enabled" or "Player vs Player Disabled", "Toggle PVP is ON", do Log off and log on
   Result: "Toggle PVP is ON"
2. while "Player vs Player Enabled" and "Toggle PVP is ON", set "Player vs Player Disabled"
   Result: 5min timer is not started while in unfriendly territory
3. when is set "Player vs Player Disabled" and "Toggle PVP is ON", moving from unfriendly territory to neutral zone like Stranglethorn Vale
   Result: without timer "Toggle PVP is OFF"

Allience char in Elwynn forest (friendly territory):

1. If "Player vs Player Enabled", "Toggle PVP is ON", do Log off and log on
   Result: "Toggle PVP is ON"
2. while "Player vs Player Enabled" and "Toggle PVP is ON", set "Player vs Player Disabled", starts 5min timer
   Result: after timer runs out "Toggle PVP is OFF"
3. while "Player vs Player Enabled" and "Toggle PVP is ON", set "Player vs Player Disabled", starts 5min timer, while timer active do Log off and Log on
   Result: "Toggle PVP is OFF" (relog skipped counter)

[Killyana]

You can find all situations here https://wowwiki.fandom.com/wiki/PvP_flag

Also in a pvp realm, a Horde char in Elwynn forest will always have pvp ON and this cannot be disabled

[Faq]

@Killyana there not written what happens when timer is started and you relog.
@illfated strange as https://wowwiki.fandom.com/wiki/PvP_flag is mentioned just cities:

[Faq]

My questions were about normal realm, i don't get it now why you mention something from table under "PvP realm".
Anyway if not engaged, then pvp flag will show up only in opposite faction cities, not in other territory.

[jaxidor]

has this been fixed yet? :o very deadly bug for world pvp

[Killyana]

If you log out with the timer going on, the timer will stops and get removed, and once relog you will get the same pvp flag status as before log out.

[jaxidor]

Well, if i am an alliance and i go to orgrimmar, all the hordes that attack be get pvp flagged and it instantly goes away so i cant attack them.
so world pvp raiding the other faction etc is completely broken cus the other faction can attack you while not even getting pvp flagged properly.

[Faq]

Still wondering, how 7 months none reported this. @jaxidor try with #24372

[nerc0487]

Why has this been closed without any possible solutions being presented?

[Thanathros]

24372 was presented as fix.

[offl]

Is this issue still valid?

[Thanathros]

It's closed and a Fix was merged. As long as no one is giving negative feedback it seems solved imo.