Trinitycore: 3.3.5 [Hunter] Pet enter evade if mmaps active and under Cower

[junker1609]

Hello,

Description:

The hunter's pet, sometimes avoids damage and all heal in dungeons and raids, and can tank without actually suffering damage

Current behaviour:

The pet looks like it is not counted by other players / creature

Expected behaviour:

Receive heal and suffer damage.

Steps to reproduce the problem:
1-Create a hunter
2-go to dungeon with a heal, tank
3-send the pet

Branch(es):
3.3.5 branch

TC rev. hash/commit: rev. f082218c973b 2020-01-13 Unix Static

Operating system:
Ubuntu 18-64bit

[Jinnaix]

TC rev. hash/commit:
f082218c973b 2020-01-13 Unix Static

Unknown hash - Custom core?

[illfated]

Most likely. If you look at the 3.3.5 commit list, there are:

• Commits on Jan 14, 2020
• Commits on Jan 12, 2020

... but no commits made on 2020-01-13. Heh, if I had noticed anything like this while playing on https://tcubuntu.northeurope.cloudapp.azure.com/ , I would have finished all the classic & TBC dungeons on my current test character, then reported the issue here. I have been looking for a way to cheat with an uber pet tank, just to compensate for playing without any other players and run through as much content as possible in my spare time. 🐈 🏹 🕺 💃 🐕 🔫

---

edit: Just to reply properly to the reported issue above (not existing in clean TC source), my pets have died frequently when I focus on keeping my own player threat below 80% -- 90%. I am also able to heal my pets, but not enough to counter massive elite damage (giants & mechanical NPCs same or almost equal level to my own character). I sometimes resort to using cheat spells (Argent Cannon Assault / 57387) or the GM command .damage to get through dungeons, if I find it necessary to follow through on a long quest chain.

[junker1609]

TC rev. hash/commit:
f082218c973b 2020-01-13 Unix Static

Unknown hash - Custom core?

I don't know, i just added transmogrification and git pull updates

Core Version :
TrinityCore rev. f082218c973b 2020-01-13 10:40:43 +0100 (3.3.5 branch) (Unix, RelWithDebInfo, Static)

Core Revision :
f082218c973b

db_version :
TDB 335.19121
@illfated I don't know, at worst I invite you to test with us =)

[Killyana]

Could provide the position where this happen (.gps) ? or a screen/video

[junker1609]

Could provide the position where this happen (.gps) ? or a screen/video

I'll rush tomorrow and try to make a video.
Thank you.

[illfated]

I don't know, i just added transmogrification and git pull updates

Core Version :
TrinityCore rev. f082218c973b 2020-01-13 10:40:43 +0100 (3.3.5 branch) (Unix, RelWithDebInfo, Static)

if nothing else, in theory there is a chance that the transmogrification code and updates could have messed with some of the spell source code to make a deviation in spell handling.

[jackpoz]

@junker1609 try with a clean 3.3.5

[jackpoz]

@illfated my favourite one is https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=30839 :)

[illfated]

@illfated my favourite one is https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=30839 :)

😃 Oh yeah, right. I remember you mentioned that one earlier and I have tried it before. Very useful. Thanks. 👍

[junker1609]

[EDIT] ADD VIDEO LINK
Hello,
There's screenshot, and i'll upload video in a few minutes,
I also noticed that it makes bosses, trash or any other creature regen when they change targets while in combat
Screen : https://ibb.co/VTSvRJg
Video : https://www.youtube.com/watch?v=LD5__JxDqLI ( from a player on our server )

[Killyana]

Any idea since when it starts to happen?
This is the only recent commit that could be related to the issue https://github.com/TrinityCore/TrinityCore/commit/2b024e8fbff24b071217cd88f052fdeaa48b47ba
Try to reverted and see if the issue is fixed or not.

[junker1609]

On the video you can see, when we start the fight, the pet manages to avoid all attacks and even heal sometimes
I'll try with the update,
I will keep you informed @Killyana

[jackpoz]

Was that from a clean 335 ? Maybe try to reproduce it on the test realm at https://tcubuntu.northeurope.cloudapp.azure.com/

[junker1609]

Was that from a clean 335 ? Maybe try to reproduce it on the test realm at https://tcubuntu.northeurope.cloudapp.azure.com/

Hello,
I create account but i have this error "unable to validate game version wow.."
Client version 3.3.5 12340 June 24, 2010

[Killyana]

The issue was also reported by Aokromes, so confirmed

[junker1609]

We will do our best to fix it all together.

[Killyana]

Please test after https://github.com/TrinityCore/TrinityCore/commit/9f8477cd112bf0f52e23afc9cdee4adfcf540de5

[Aokromes]

at least evade issues got fixed acording who told me.

[Killyana]

This issue could be reproduced with Dummy, just activate cower (auto) https://woehead.way-of-elendil.fr/?spell=1742 and send your pet hit the dummy you will get evades from the pet and some logs:
Diablosaure DAMAGE_SHIELD_MISSED_EVADE Assoiffé de sang Diablosaure.
Diablosaure DAMAGE_SHIELD_MISSED_EVADE Force monstrueuse Diablosaure.

[illfated]

Interesting combination, mmaps = 1 and Cower = auto. I will log into tcubuntu.northeurope.cloudapp.azure.com and test my pets there to see what the current status is.

[jackpoz]

please try after https://github.com/TrinityCore/TrinityCore/commit/d293dd37822d93f9023d3ff9d39052ed976e236b

[jackpoz]

btw @junker1609 you could push your fork with your changes (transmog patch) to GitHub so we know which commit and which custom changes you are using, win-win for both :)

[junker1609]

It seems to me that it is resolved for the moment for me.
If someone can also confirm.
@jackpoz I will upload it during the week