Trinitycore: Core/Profession: Skill Tailoring does not level up

[buddyqc69]

Description:

Description of the problem or issue here.
after have learn the skill, i want to levelup the skill on crafting items but doesnt work,stuck at 0/0

Tell us what happens.
just nothing, stuck at 0/0

Tell us what should happen instead.
after learning tailoring, we can create items but it does not raise the level of the profession

Steps to reproduce the problem:

Step 1:
learn skill 197 https://www.wowhead.com/tailoring

1. Step 2 craft the items basics
2. Step 3 dont levelup the skill of the profession

Branch(es):
master

TC rev. hash/commit:
TrinityCore rev. d101038 2019-12-17 01:23:24 +0100 (master branch) (Win64, Release, Static)

we dont have error in the console, that good but is doesnt work.

Operating system:
Windows Server 2016 x64 last update

Others:
Like this issues: https://github.com/TrinityCore/TrinityCore/issues/24022
after learn the skill is good but is not possible to upgrade the skill profession.

i have checked the skill like "tail" on mysql server and we have found this:
TC> lookup skill tail
197 - Tailoring (that the skill i learn..)
2533 - Kul Tiran Tailoring
2534 - Legion Tailoring
2535 - Draenor Tailoring
2536 - Pandaria Tailoring
2537 - Cataclysm Tailoring
2538 - Northrend Tailoring
2539 - Outland Tailoring
2540 - Tailoring (is not the real skill operationnal ?)

sorry for my bad english

[Shauren]

Your step 1 is the reason why it does not work for you. Cast 264617 (not learn) on yourself and watch it automatically work. (this spell should be on trainer, not 3911)

[buddyqc69]

After having .cast 264617 the skill, I have to log out and log back in and the professions work, where could the problem come from?

[buddyqc69]

Im better in MySQL, but i think that beacause the professions i learn he doesnt not refresh ?

[buddyqc69]

that before reconnect, i have learn the spell with the trainer.

that after reconnect

why don't refresh the correct level ?

[buddyqc69]

in the "skill_tiers" table, is supposed have skillID 2540 or 197 inside i think right ?

[buddyqc69]

Ok that levelup now but i not possible to buy another items for progress

[Killyana]

Spells in the table are wrong they must all be updated, otherwise you cannot level up properly.

[buddyqc69]

I can help you to debug this?

[Killyana]

There is nothing to debug we need just to put the correct data in the table.

[buddyqc69]

What table should be corrected? I will try to fix it :) I love working with mysql

[Killyana]

trainer_spell

[ReyDonovan]

DELETE FROM `trainer` WHERE `Id` IN (857, 841, 983, 832, 858);
INSERT INTO `trainer` (`Id`, `Type`, `Greeting`, `VerifiedBuild`) VALUES
(857, 2, 'Хочешь, научу, как устроить из добычи настоящее пиршество?', 27602),
(841, 2, 'Кто никогда не рылся в земле, тот, считай, и не жил!', 27602),
(983, 2, 'Привет.', 27602),
(832, 2, 'Наложение чар – это искусство улучшения материальных объектов с помощью магии.', 27602),
(858, 2, 'Хочешь, научу, как устроить из добычи настоящее пиршество?', 27602);


DELETE FROM `trainer_spell` WHERE (`TrainerId`=857 AND `SpellId`=259446) OR (`TrainerId`=857 AND `SpellId`=259415) OR (`TrainerId`=857 AND `SpellId`=259436) OR (`TrainerId`=857 AND `SpellId`=259414) OR (`TrainerId`=857 AND `SpellId`=259440) OR (`TrainerId`=857 AND `SpellId`=259443) OR (`TrainerId`=857 AND `SpellId`=259412) OR (`TrainerId`=857 AND `SpellId`=259437) OR (`TrainerId`=857 AND `SpellId`=259419) OR (`TrainerId`=857 AND `SpellId`=259445) OR (`TrainerId`=857 AND `SpellId`=259434) OR (`TrainerId`=857 AND `SpellId`=259439) OR (`TrainerId`=857 AND `SpellId`=259424) OR (`TrainerId`=857 AND `SpellId`=259431) OR (`TrainerId`=857 AND `SpellId`=259418) OR (`TrainerId`=857 AND `SpellId`=259421) OR (`TrainerId`=857 AND `SpellId`=259428) OR (`TrainerId`=857 AND `SpellId`=259427) OR (`TrainerId`=857 AND `SpellId`=259433) OR (`TrainerId`=857 AND `SpellId`=259411) OR (`TrainerId`=857 AND `SpellId`=259425) OR (`TrainerId`=857 AND `SpellId`=264633) OR (`TrainerId`=857 AND `SpellId`=264647) OR (`TrainerId`=841 AND `SpellId`=253336) OR (`TrainerId`=841 AND `SpellId`=253342) OR (`TrainerId`=841 AND `SpellId`=253345) OR (`TrainerId`=841 AND `SpellId`=253339) OR (`TrainerId`=841 AND `SpellId`=253333) OR (`TrainerId`=841 AND `SpellId`=265852) OR (`TrainerId`=841 AND `SpellId`=265838) OR (`TrainerId`=983 AND `SpellId`=89129) OR (`TrainerId`=983 AND `SpellId`=89723) OR (`TrainerId`=983 AND `SpellId`=89725) OR (`TrainerId`=983 AND `SpellId`=201709) OR (`TrainerId`=983 AND `SpellId`=110394) OR (`TrainerId`=983 AND `SpellId`=80836) OR (`TrainerId`=983 AND `SpellId`=89726) OR (`TrainerId`=983 AND `SpellId`=89727) OR (`TrainerId`=983 AND `SpellId`=278912) OR (`TrainerId`=983 AND `SpellId`=158763) OR (`TrainerId`=983 AND `SpellId`=89724) OR (`TrainerId`=832 AND `SpellId`=278418) OR (`TrainerId`=832 AND `SpellId`=269715) OR (`TrainerId`=832 AND `SpellId`=271366) OR (`TrainerId`=832 AND `SpellId`=271433) OR (`TrainerId`=832 AND `SpellId`=268913) OR (`TrainerId`=832 AND `SpellId`=268907) OR (`TrainerId`=832 AND `SpellId`=268894) OR (`TrainerId`=832 AND `SpellId`=268895) OR (`TrainerId`=832 AND `SpellId`=268908) OR (`TrainerId`=832 AND `SpellId`=268852) OR (`TrainerId`=832 AND `SpellId`=268901) OR (`TrainerId`=832 AND `SpellId`=268878) OR (`TrainerId`=832 AND `SpellId`=268914) OR (`TrainerId`=832 AND `SpellId`=268902) OR (`TrainerId`=832 AND `SpellId`=255092) OR (`TrainerId`=832 AND `SpellId`=255075) OR (`TrainerId`=832 AND `SpellId`=255077) OR (`TrainerId`=832 AND `SpellId`=255129) OR (`TrainerId`=832 AND `SpellId`=255087) OR (`TrainerId`=832 AND `SpellId`=255091) OR (`TrainerId`=832 AND `SpellId`=255142) OR (`TrainerId`=832 AND `SpellId`=255078) OR (`TrainerId`=832 AND `SpellId`=255141) OR (`TrainerId`=832 AND `SpellId`=255103) OR (`TrainerId`=832 AND `SpellId`=255093) OR (`TrainerId`=832 AND `SpellId`=255073) OR (`TrainerId`=832 AND `SpellId`=255076) OR (`TrainerId`=832 AND `SpellId`=255130) OR (`TrainerId`=832 AND `SpellId`=255072) OR (`TrainerId`=832 AND `SpellId`=255111) OR (`TrainerId`=832 AND `SpellId`=265110) OR (`TrainerId`=832 AND `SpellId`=255110) OR (`TrainerId`=832 AND `SpellId`=255090) OR (`TrainerId`=832 AND `SpellId`=255104) OR (`TrainerId`=832 AND `SpellId`=255088) OR (`TrainerId`=832 AND `SpellId`=255086) OR (`TrainerId`=832 AND `SpellId`=265106) OR (`TrainerId`=832 AND `SpellId`=255089) OR (`TrainerId`=832 AND `SpellId`=255071) OR (`TrainerId`=832 AND `SpellId`=265111) OR (`TrainerId`=832 AND `SpellId`=267458) OR (`TrainerId`=832 AND `SpellId`=267486) OR (`TrainerId`=832 AND `SpellId`=267482) OR (`TrainerId`=832 AND `SpellId`=267490) OR (`TrainerId`=832 AND `SpellId`=267495) OR (`TrainerId`=832 AND `SpellId`=265806) OR (`TrainerId`=832 AND `SpellId`=264457) OR (`TrainerId`=858 AND `SpellId`=259446) OR (`TrainerId`=858 AND `SpellId`=259415) OR (`TrainerId`=858 AND `SpellId`=259436) OR (`TrainerId`=858 AND `SpellId`=259414) OR (`TrainerId`=858 AND `SpellId`=259440) OR (`TrainerId`=858 AND `SpellId`=259443) OR (`TrainerId`=858 AND `SpellId`=259412) OR (`TrainerId`=858 AND `SpellId`=259437) OR (`TrainerId`=858 AND `SpellId`=259419) OR (`TrainerId`=858 AND `SpellId`=259445) OR (`TrainerId`=858 AND `SpellId`=259434) OR (`TrainerId`=858 AND `SpellId`=259439) OR (`TrainerId`=858 AND `SpellId`=259424) OR (`TrainerId`=858 AND `SpellId`=259431) OR (`TrainerId`=858 AND `SpellId`=259418) OR (`TrainerId`=858 AND `SpellId`=259421) OR (`TrainerId`=858 AND `SpellId`=259428) OR (`TrainerId`=858 AND `SpellId`=259427) OR (`TrainerId`=858 AND `SpellId`=259433) OR (`TrainerId`=858 AND `SpellId`=259411) OR (`TrainerId`=858 AND `SpellId`=259425) OR (`TrainerId`=858 AND `SpellId`=264633) OR (`TrainerId`=858 AND `SpellId`=265818);
INSERT INTO `trainer_spell` (`TrainerId`, `SpellId`, `MoneyCost`, `ReqSkillLine`, `ReqSkillRank`, `ReqAbility1`, `ReqAbility2`, `ReqAbility3`, `ReqLevel`, `VerifiedBuild`) VALUES
(857, 259446, 405000, 2541, 75, 259445, 0, 0, 0, 27602),
(857, 259415, 405000, 2541, 75, 259414, 0, 0, 0, 27602),
(857, 259436, 225000, 2541, 10, 0, 0, 0, 0, 27602),
(857, 259414, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259440, 405000, 2541, 75, 259439, 0, 0, 0, 27602),
(857, 259443, 315000, 2541, 35, 259442, 0, 0, 0, 27602),
(857, 259412, 315000, 2541, 35, 259411, 0, 0, 0, 27602),
(857, 259437, 315000, 2541, 35, 259436, 0, 0, 0, 27602),
(857, 259419, 405000, 2541, 75, 259418, 0, 0, 0, 27602),
(857, 259445, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259434, 405000, 2541, 75, 259433, 0, 0, 0, 27602),
(857, 259439, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259424, 225000, 2541, 10, 0, 0, 0, 0, 27602),
(857, 259431, 270000, 2541, 15, 259430, 0, 0, 0, 27602),
(857, 259418, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259421, 540000, 2541, 110, 0, 0, 0, 0, 27602),
(857, 259428, 405000, 2541, 75, 259427, 0, 0, 0, 27602),
(857, 259427, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259433, 337500, 2541, 50, 0, 0, 0, 0, 27602),
(857, 259411, 225000, 2541, 10, 0, 0, 0, 0, 27602),
(857, 259425, 315000, 2541, 35, 259424, 0, 0, 0, 27602),
(857, 264633, 9, 0, 0, 0, 0, 0, 5, 27602),
(857, 264647, 450000, 185, 1, 0, 0, 0, 110, 27602),
(841, 253336, 315000, 2565, 1, 0, 0, 0, 0, 27602),
(841, 253342, 450000, 2565, 25, 0, 0, 0, 0, 27602),
(841, 253345, 450000, 2565, 25, 0, 0, 0, 0, 27602),
(841, 253339, 450000, 2565, 25, 0, 0, 0, 0, 27602),
(841, 253333, 315000, 2565, 1, 0, 0, 0, 0, 27602),
(841, 265852, 450000, 186, 1, 0, 0, 0, 110, 27602),
(841, 265838, 9, 0, 0, 0, 0, 0, 5, 27602),
(983, 89129, 1000, 0, 0, 78670, 0, 0, 20, 27602),
(983, 89723, 1000, 0, 0, 88961, 0, 0, 20, 27602),
(983, 89725, 100000, 0, 0, 89719, 0, 0, 50, 27602),
(983, 201709, 900000, 0, 0, 158762, 0, 0, 98, 27602),
(983, 110394, 600000, 0, 0, 89722, 0, 0, 80, 27602),
(983, 80836, 1000, 0, 0, 0, 0, 0, 20, 27602),
(983, 89726, 150000, 0, 0, 89720, 0, 0, 65, 27602),
(983, 89727, 250000, 0, 0, 89721, 0, 0, 75, 27602),
(983, 278912, 1200000, 0, 0, 195127, 0, 0, 110, 27602),
(983, 158763, 600000, 0, 0, 110393, 0, 0, 90, 27602),
(983, 89724, 25000, 0, 0, 89718, 0, 0, 35, 27602),
(832, 278418, 500000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 269715, 400000, 2486, 85, 0, 0, 0, 0, 27602),
(832, 271366, 280000, 2486, 10, 0, 0, 0, 0, 27602),
(832, 271433, 280000, 2486, 10, 0, 0, 0, 0, 27602),
(832, 268913, 350000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 268907, 350000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 268894, 350000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 268895, 750000, 2486, 125, 268894, 0, 0, 0, 27602),
(832, 268908, 750000, 2486, 125, 268907, 0, 0, 0, 27602),
(832, 268852, 350000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 268901, 350000, 2486, 60, 0, 0, 0, 0, 27602),
(832, 268878, 750000, 2486, 125, 268852, 0, 0, 0, 27602),
(832, 268914, 750000, 2486, 125, 268913, 0, 0, 0, 27602),
(832, 268902, 750000, 2486, 125, 268901, 0, 0, 0, 27602),
(832, 255092, 600000, 2486, 100, 255077, 0, 0, 0, 27602),
(832, 255075, 375000, 2486, 75, 0, 0, 0, 0, 27602),
(832, 255077, 375000, 2486, 75, 0, 0, 0, 0, 27602),
(832, 255129, 325000, 2486, 40, 0, 0, 0, 0, 27602),
(832, 255087, 300000, 2486, 35, 255072, 0, 0, 0, 27602),
(832, 255091, 600000, 2486, 100, 255076, 0, 0, 0, 27602),
(832, 255142, 500000, 2486, 95, 255141, 0, 0, 0, 27602),
(832, 255078, 375000, 2486, 75, 0, 0, 0, 0, 27602),
(832, 255141, 325000, 2486, 40, 0, 0, 0, 0, 27602),
(832, 255103, 325000, 2486, 40, 0, 0, 0, 0, 27602),
(832, 255093, 600000, 2486, 100, 255078, 0, 0, 0, 27602),
(832, 255073, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 255076, 375000, 2486, 75, 0, 0, 0, 0, 27602),
(832, 255130, 500000, 2486, 95, 255129, 0, 0, 0, 27602),
(832, 255072, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 255111, 500000, 2486, 95, 255110, 0, 0, 0, 27602),
(832, 265110, 400000, 2486, 85, 0, 0, 0, 0, 27602),
(832, 255110, 325000, 2486, 40, 0, 0, 0, 0, 27602),
(832, 255090, 600000, 2486, 100, 255075, 0, 0, 0, 27602),
(832, 255104, 500000, 2486, 95, 255103, 0, 0, 0, 27602),
(832, 255088, 300000, 2486, 35, 255073, 0, 0, 0, 27602),
(832, 255086, 300000, 2486, 35, 255071, 0, 0, 0, 27602),
(832, 265106, 280000, 2486, 10, 0, 0, 0, 0, 27602),
(832, 255089, 300000, 2486, 35, 255074, 0, 0, 0, 27602),
(832, 255071, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 265111, 600000, 2486, 100, 265110, 0, 0, 0, 27602),
(832, 267458, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 267486, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 267482, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 267490, 250000, 2486, 1, 0, 0, 0, 0, 27602),
(832, 267495, 280000, 2486, 10, 0, 0, 0, 0, 27602),
(832, 265806, 500000, 333, 1, 0, 0, 0, 110, 27602),
(832, 264457, 10, 0, 0, 0, 0, 0, 5, 27602),
(858, 259446, 382500, 2541, 75, 259445, 0, 0, 0, 27602),
(858, 259415, 382500, 2541, 75, 259414, 0, 0, 0, 27602),
(858, 259436, 212500, 2541, 10, 0, 0, 0, 0, 27602),
(858, 259414, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259440, 382500, 2541, 75, 259439, 0, 0, 0, 27602),
(858, 259443, 297500, 2541, 35, 259442, 0, 0, 0, 27602),
(858, 259412, 297500, 2541, 35, 259411, 0, 0, 0, 27602),
(858, 259437, 297500, 2541, 35, 259436, 0, 0, 0, 27602),
(858, 259419, 382500, 2541, 75, 259418, 0, 0, 0, 27602),
(858, 259445, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259434, 382500, 2541, 75, 259433, 0, 0, 0, 27602),
(858, 259439, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259424, 212500, 2541, 10, 0, 0, 0, 0, 27602),
(858, 259431, 255000, 2541, 15, 259430, 0, 0, 0, 27602),
(858, 259418, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259421, 510000, 2541, 110, 0, 0, 0, 0, 27602),
(858, 259428, 382500, 2541, 75, 259427, 0, 0, 0, 27602),
(858, 259427, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259433, 318750, 2541, 50, 0, 0, 0, 0, 27602),
(858, 259411, 212500, 2541, 10, 0, 0, 0, 0, 27602),
(858, 259425, 297500, 2541, 35, 259424, 0, 0, 0, 27602),
(858, 264633, 8, 0, 0, 0, 0, 0, 5, 27602),
(858, 265818, 425000, 185, 1, 0, 0, 0, 110, 27602);


DELETE FROM `creature_default_trainer` WHERE `CreatureId` IN (122701, 141549);
INSERT INTO `creature_default_trainer` (`CreatureId`, `TrainerId`) VALUES
(122701, 983),
(141549, 858);

[buddyqc69]

is not the same NPC ?

[ReyDonovan]

some_data_trainer_Kul Tiran.zip

[buddyqc69]

you update SQL that for drustvar ok good is not for the npc at orgrimmar :S

https://www.wowhead.com/npc=3363/magar

[illfated]

@ReyDonovan : Could you edit your SQL content to use ```sql

instead of your current ```css as the syntax highlighting code?

[buddyqc69]

i understand why the skill doesnt work, because is not saved in the database characters -> character_skills, i have added my skill and is work now after relog but is not updated if levelup the skill, can you said to me how to fix that ?

EDIT: after added the skill to my characters database on character_skills after reconnect and levelup that save my skill.

We need to save the progress of the skill in the database, that like cache memory our professions..

[buddyqc69]

all profession is not saved in the database "characters -> character_skills" do you have fix for this ?

[matanshukry]

@buddyqc69

From checking on the latest version:

• The tailoring trainer spell is incorrect
• If I use the correct spell that @Shauren provided, 264617, I learn the tailoring and it's working correctly; I can level it, and it will persist even after I restart the server.

As far as I can tell the only issue here is the spells are incorrect - hence database only, and not core (like the title suggests).

[illfated]

Fair point. Title suggestion:

Core/Profession: Skill Tailoring does not level up --> DB/Profession: Tailoring skill does not level up

edit: @buddyqc69 : Would it be OK for you to change the ticket title as suggested?

[NiganNi]

Skill is being pumped, but the coach has no opportunity to study further.

[matanshukry]

@NiganNi I don't know russian, but looking at the images I'm guessing you're talking about different types of tailoring.
The game divides each profession into multiple, by expansion. That is, there is "Tailoring"(Classic Tailoring), "Cataclysm Tailoring", etc.

Make sure the skill you're trying to learn make the same points you already have.
If that is the case, please provide the same image in English.

[NiganNi]

Hi guys, I managed to upgrade my sewing to 300, what should I do next? Wouldn't it be wrong if I just dropped my unlearned skills?

[matanshukry]

@NiganNi why would you unlearn it?
The original issue that you can't level up tailoring has been fixed btw according to you, so this issue should be closed.
The "next" thing you should do is go to the next trainer (e.g. outland tailoring, a tailoring trainer in outland).

Regarding the patterns you see there - their data in tdb is incorrect; they don't have the correct questline and level (probably other info too). I'll try to ask for the data for it soon, but feel free to open an issue - it would also help me not forget it xd