Trinitycore: Hunter/Spell : Feign Death doesn't clear threat

[Jinnaii]

Description:

Hunters Feign Death is their only threat reduce mechanic.
Used in Bossfight where Feign Death does not take you out of combat (as intended) it should reset (or reduce?) your threat.

This can also be used in dungeons as a means of periodically wiping aggro, thereby allowing the Hunter to do more damage without drawing aggro away from the tank. The only drawback is the 30 second cooldown (starts after feign death is canceled), which means players should be careful not to use this strategy when feign death may be needed more urgently later in the fight. On bosses such as Onyxia, you'll want to use Feign Death as often as it is available. As of patch 3.0.2, Feign Death is the only way a hunter can reduce their aggro due to the changes to Disengage's mechanics.

Current behaviour:

Using Feign Death in a Bossfight does not wipe/reduce your threat.

Expected behaviour:

It should.

Steps to reproduce the problem:

Might be doable with a pet too but i tested this with another player :
Level up a hunter to learn Feign Death.
Take a second Character (Friend/Second WoW/whatever) with you.
Let the other Character attack a Boss (we used Razorgor to keep it simple) to build up some aggro.
Let the other Character stop attacking.
Start attacking yourself until you gain aggro from boss.
Use Feign Death. Boss should attack second Character now.
Cancel Feign Death. Your previously build threat will reappear and Boss will attack you again.

Branch(es):

3.3.5

TC rev. hash/commit:

30823f9b79b4ad16f96e90692a900f68a7f63c0a

Operating system: Windows 10

[illfated]

(just to avoid confusion with the Warhammer creature Razorgor)

• https://classic.wowhead.com/npc=12435/razorgore-the-untamed

[Jildor]

seems same as: https://github.com/TrinityCore/TrinityCore/issues/23567

when @Treeston did Combat/threat system rewrite, was removed target->getHostileRefManager().deleteReferences(); in feign death: https://github.com/TrinityCore/TrinityCore/commit/532ab1c7f8653d1a2e48aa1f1f8a9ba1041d4bb7#diff-e896389d5b1073efabc2ffa33ec49d55L2170

Related commits:
Core: Combat/threat system rewrite: https://github.com/TrinityCore/TrinityCore/commit/532ab1c7f8653d1a2e48aa1f1f8a9ba1041d4bb7#diff-e896389d5b1073efabc2ffa33ec49d55L2170
and Core/Threat: Threat system adjustments: https://github.com/TrinityCore/TrinityCore/commit/5cea572a9ad524c6f28ff8519bee61d1ff4357d0#diff-e896389d5b1073efabc2ffa33ec49d55L2240

Maybe @Treeston can explain if it's intended or not.

[Keader]

i dont think it should clear threat...
I remember that clear threat allow exploits like reset some spells and potions cooldown, cause it will make you drop combat.
If i remember right it should:
If you are the only target of boss -> he needs reset.
If have more people, boss should ignore you and go to the next target.
So... i belive that spell should set your threat to 0, but not clear it.

[Jildor]

So you're saying we need create a spell_script for feign death and add somethink to reduce 99% thread of nearby enemies? (if is encounter with a boss)

[illfated]

If the threat amount is 100% on the hunter, I read Keader's comment to mean that threat should reset to 0% (or whatever the % value is supposed to be, set by the Feign Death spell), but not remove the hunter from the threat list. Maybe 99% is appropriate, I don't remember the correct % values for Feign Death.

[Treeston]

Not able to invest any time right now, but if you want FD to reset threat, just set threat to 0 in AuraEffect::HandleFeignDeath.

for (auto& pair : target->GetThreatManager().GetThreatenedByMeList())
  pair.second->ScaleThreat(0.0f);

[Killyana]

The only issue is when you cancel feign death (against a boss) your initial threat will be restored, it must probably be set to 0.
The fix above works fine, I tested it with boss and outside dungeons.