Trinitycore: Loading saved respawn time messages spam during server startup

[Vasago]

Description:

There are too many messages after update TrinityCore in server log when server is starting up connected to respawns.

Current behaviour:

There are errors after update TrinityCore in log when server is starting connected to respawns.
It does not get deleted after some time.
It stucks there every startup.

Expected behaviour:

There should not be these messages in so many count.
"Loading saved respawn time of XXXXXXXX for spawnid (XXXXX) - spawn does not exist, ignoring.

Steps to reproduce the problem:

1) Update Trinity to the https://github.com/TrinityCore/TrinityCore/commit/af874a211c0f064bd685cddeded3ca7d6d690e8f (from 4 months old core)
2) See the startup messages spam.
3) See log: https://pastebin.com/935UYizM

=> The structure of the logs is also wrong it seems - it says spawnid (0,302075) etc.
=> Should we truncate the table to fill it in with the correct data after server resets all instances?

Branch(es):

3.3.5

TC rev. hash/commit:

https://github.com/TrinityCore/TrinityCore/commit/af874a211c0f064bd685cddeded3ca7d6d690e8f

Operating system: Debian Linux 64bit

[Treeston]

Should probably make the core delete those respawns on first startup.

[truliaswotlk]

I have noticed this too on updating from revision to revision. It only happens for me after making a change to the character database. It disappeared after executing the base sql for characters in the trinity source folder. I assumed the respawn messages were related to where my characters were logged in. What I did was did a pdump write and pdump load of all server characters v's all other characters transfer methods and the respawn message went bye bye. I deleted my logs and it remains gone afterwards. Hope this info helps in some way as it is the only repsawn message I have ever seen and what I did fixes it.

[illfated]

I get only 4 warning lines when I start up my local server, so I guess that is because 4 of my characters are old ones, while the rest are fairly recent.

[Ovahlord]

Truncate your respawn tables. The respawns times prior to the update are no longer compatible with the new handlings because they did not get converted properly.
It's not a real issue but more a bad conversion process

[D-CellX]

Even if you truncate the table, after few days of character activity, the errors/warnings reappear.

[Shauren]

Are these outdoorpvp respawns?

[Killyana]

No it's just related to creature + gob respawn Unified into the same table
https://github.com/TrinityCore/TrinityCore/commit/374597c8e96c886f1e3647d405bf3160c8b98bf8
As old data wasn't converted or deleted it gives this errors.
Just delete this lines or everything in the table, there's no generic solution.

[Shauren]

I said that because outdoorpvp scripts create new spawnids on every restart (yes, they keep incrementing db guids constantly)

[Killyana]

It could be, some of this guids are too high:
2019-08-13_10:47:46 Loading saved respawn time of 1283625335 for spawnid (0,10921315) - spawn does not exist, ignoring

[Killyana]

This could be used to clean the respawn table, but will not be committed as DB names could be different
``sql DELETE FROMrespawnWHEREtype=0 ANDspawnIdNOT IN (SELECTguidFROMworld.creature); DELETE FROMrespawnWHEREtype=1 ANDspawnIdNOT IN (SELECTguidFROMworld.gameobject`);