Description:
Implement scripts Howling Fjord NPC Gjalerbron Sleep-Watcher (23989), Gjalerbron Rune-Caster (23990), Gjalerbron Warrior (23991), and Fearsome Horror (24073).
Branch(es):
3.3.5 and master
TC rev. hash/commit:
TrinityCore rev. 0cbdbd8a3f3c 2019-01-17 17:34:10 +0100 (3.3.5 branch) (Unix, Debug, Static) (worldserver-daemon)
TDB version: 335.64
Operating system: *nix
Suggested Fix:
-- Gjalerbron Sleep-Watcher (23989)
DELETE FROM `creature_text` WHERE `CreatureID`=23989;
INSERT INTO `creature_text` (`CreatureID`,`GroupID`,`ID`,`Text`,`Type`,`Language`,`Probability`,`Emote`,`Duration`,`Sound`,`BroadcastTextId`,`TextRange`,`comment`) VALUES
(23989,0,0,"For Ymiron!",12,0,100,0,0,0,22697,0,'Gjalerbron Sleep-Watcher'),
(23989,0,1,"YAAARRRGH!",12,0,100,0,0,13535,22700,0,'Gjalerbron Sleep-Watcher'),
(23989,0,2,"My life for Ymiron!",12,0,100,0,0,0,22702,0,'Gjalerbron Sleep-Watcher'),
(23989,0,3,"You tiny creatures disgust me!",12,0,100,0,0,0,22816,0,'Gjalerbron Sleep-Watcher'),
(23989,0,4,"Look what''s come to play.",12,0,100,0,0,0,22820,0,'Gjalerbron Sleep-Watcher'),
(23989,0,5,"There will be no everlasting life for you!",12,0,100,0,0,0,22822,0,'Gjalerbron Sleep-Watcher'),
(23989,0,6,"I will break you!",12,0,100,0,0,0,22823,0,'Gjalerbron Sleep-Watcher'),
(23989,0,7,"Your race is a disease upon the world!",12,0,100,0,0,0,22824,0,'Gjalerbron Sleep-Watcher'),
(23989,0,8,"I will take pleasure in gutting you!",12,0,100,0,0,0,30498,0,'Gjalerbron Sleep-Watcher'),
(23989,0,9,"I will feed you to the dogs!",12,0,100,0,0,13534,30499,0,'Gjalerbron Sleep-Watcher'),
(23989,0,10,"Your entrails will make a fine necklace.",12,0,100,0,0,0,30500,0,'Gjalerbron Sleep-Watcher'),
(23989,0,11,"Die, maggot!",12,0,100,0,0,0,30501,0,'Gjalerbron Sleep-Watcher'),
(23989,0,12,"You come to die!",12,0,100,0,0,0,30502,0,'Gjalerbron Sleep-Watcher'),
(23989,0,13,"I spit on you!",12,0,100,0,0,13538,30503,0,'Gjalerbron Sleep-Watcher'),
(23989,0,14,"Sniveling pig!",12,0,100,0,0,0,30504,0,'Gjalerbron Sleep-Watcher'),
(23989,0,15,"Ugglin oo bjorr!",12,0,100,0,0,0,30505,0,'Gjalerbron Sleep-Watcher'),
(23989,0,16,"Haraak foln!",12,0,100,0,0,0,30506,0,'Gjalerbron Sleep-Watcher'),
(23989,0,17,"I'll eat your heart!",12,0,100,0,0,13542,30508,0,'Gjalerbron Sleep-Watcher');
DELETE FROM `smart_scripts` WHERE `entryorguid`=23989 AND `source_type`=0 AND `id`=2;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(23989,0,2,0,0,0,100,0,8000,10000,18000,22000,0,11,15970,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"Gjalerbron Sleep-Watcher - In Combat - Cast 'Sleep'");
-- Gjalerbron Rune-Caster (23990)
DELETE FROM `creature_text` WHERE `CreatureID`=23990;
INSERT INTO `creature_text` (`CreatureID`,`GroupID`,`ID`,`Text`,`Type`,`Language`,`Probability`,`Emote`,`Duration`,`Sound`,`BroadcastTextId`,`TextRange`,`comment`) VALUES
(23990,0,0,"For Ymiron!",12,0,100,0,0,0,22697,0,'Gjalerbron Rune-Caster'),
(23990,0,1,"YAAARRRGH!",12,0,100,0,0,13535,22700,0,'Gjalerbron Rune-Caster'),
(23990,0,2,"My life for Ymiron!",12,0,100,0,0,0,22702,0,'Gjalerbron Rune-Caster'),
(23990,0,3,"You tiny creatures disgust me!",12,0,100,0,0,0,22816,0,'Gjalerbron Rune-Caster'),
(23990,0,4,"There will be no everlasting life for you!",12,0,100,0,0,0,22822,0,'Gjalerbron Rune-Caster'),
(23990,0,5,"I will break you!",12,0,100,0,0,0,22823,0,'Gjalerbron Rune-Caster'),
(23990,0,6,"Your race is a disease upon the world!",12,0,100,0,0,0,22824,0,'Gjalerbron Rune-Caster'),
(23990,0,7,"I will take pleasure in gutting you!",12,0,100,0,0,0,30498,0,'Gjalerbron Rune-Caster'),
(23990,0,8,"I will feed you to the dogs!",12,0,100,0,0,13534,30499,0,'Gjalerbron Rune-Caster'),
(23990,0,9,"Your entrails will make a fine necklace.",12,0,100,0,0,0,30500,0,'Gjalerbron Rune-Caster'),
(23990,0,10,"Die, maggot!",12,0,100,0,0,0,30501,0,'Gjalerbron Rune-Caster'),
(23990,0,11,"You come to die!",12,0,100,0,0,0,30502,0,'Gjalerbron Rune-Caster'),
(23990,0,12,"I spit on you!",12,0,100,0,0,13538,30503,0,'Gjalerbron Rune-Caster'),
(23990,0,13,"Sniveling pig!",12,0,100,0,0,0,30504,0,'Gjalerbron Rune-Caster'),
(23990,0,14,"Haraak foln!",12,0,100,0,0,0,30506,0,'Gjalerbron Rune-Caster'),
(23990,0,15,"I'll eat your heart!",12,0,100,0,0,13542,30508,0,'Gjalerbron Rune-Caster');
DELETE FROM `smart_scripts` WHERE `entryorguid`=23990 AND `source_type`=0 AND `id` IN (2,3,4);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(23990,0,2,0,0,0,100,0,1000,3500,8000,12000,0,11,43453,0,33,0,0,0,1,0,0,0,0,0,0,0,0,"Gjalerbron Rune-Caster - In Combat - Cast 'Rune Ward'"),
(23990,0,3,0,0,0,100,0,500,500,1500,1500,0,11,9672,0,64,0,0,0,2,0,0,0,0,0,0,0,0,"Gjalerbron Rune-Caster - In Combat - Cast 'Frostbolt'"),
(23990,0,4,0,0,0,100,0,6000,8000,10000,12000,0,11,34787,0,1,0,0,0,2,0,0,0,0,0,0,0,0,"Gjalerbron Rune-Caster - In Combat - Cast 'Freezing Circle'");
-- Gjalerbron Warrior (23991)
DELETE FROM `smart_scripts` WHERE `entryorguid`=23991 AND `source_type`=0 AND `id` IN (2,3);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(23991,0,2,0,0,0,100,0,4000,10000,35000,45000,0,11,13730,0,0,0,0,0,1,0,0,0,0,0,0,0,0,"Gjalerbron Warrior - In Combat - Cast 'Demoralizing Shout'"),
(23991,0,3,0,0,0,100,0,7000,10000,17000,20000,0,11,10966,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"Gjalerbron Warrior - In Combat - Cast 'Uppercut'");
-- Fearsome Horror (24073)
DELETE FROM `smart_scripts` WHERE `entryorguid`=24073 AND `source_type`=0 AND `id`=1;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(24073,0,2,0,0,0,100,0,2000,6000,7000,10000,0,11,49861,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"Fearsome Horror - In Combat - Cast 'Infected Bite'");
Looks good to me, visually. I presume you have tested this in-game?
Yes, I have tested. Also updated creature_text
entries, added script for Fearsome Horror.
Very good. BTW, I like to use 1 blank line before DELETE FROM
lines, but that is mostly cosmetic/codestyle.
(not between a comment line and the query, but between separate queries, like after a query ends in a ;
)
OK. Thanks for review. Added blank lines.
Missing texts:
Gjalerbron Sleep-Watcher says: Die, maggot!
Gjalerbron Sleep-Watcher says: For Ymiron!
Gjalerbron Sleep-Watcher says: Haraak foln!
Gjalerbron Sleep-Watcher says: I spit on you!
Gjalerbron Sleep-Watcher says: I will break you!
Gjalerbron Sleep-Watcher says: I will feed you to the dogs!
Gjalerbron Sleep-Watcher says: I will take pleasure in gutting you!
Gjalerbron Sleep-Watcher says: I'll eat your heart!
Gjalerbron Sleep-Watcher says: Look what's come to play.
Gjalerbron Sleep-Watcher says: My life for Ymiron!
Gjalerbron Sleep-Watcher says: Sniveling pig!
Gjalerbron Sleep-Watcher says: There will be no everlasting life for you!
Gjalerbron Sleep-Watcher says: Ugglin oo bjorr!
Gjalerbron Sleep-Watcher says: YAAARRRGH!
Gjalerbron Sleep-Watcher says: You come to die!
Gjalerbron Sleep-Watcher says: You tiny creatures disgust me!
Gjalerbron Sleep-Watcher says: Your entrails will make a fine necklace.
Gjalerbron Sleep-Watcher says: Your race is a disease upon the world!
same for https://www.wowhead.com/npc=23990/gjalerbron-rune-caster
Good point. I tested it recently and sometimes the text lines don't match the say/yell lines, maybe because of missing text.
@Sorikoff : Are you prepared to add the missing text lines? ✍️ 👨🏭 👍
edit: I meant "some times, the sound files played by the mobs don't match the say/yell text".
Sure, but a little bit later.
Updated texts. Fixed sounds.
Most helpful comment
Updated texts. Fixed sounds.