Trinitycore: [3.3.5] Worldserver.conf and timezones

[TheWinchesters]

Description:
In a local enviroment, Everything that has an "hour of the day when xxx occurs" in worldserver.conf occurs 3 hours earlier.
At least in my case, (GMT-3).

Example:
Worlserver.conf: Instance.ResetTimeHour = 4 (default)
Server: Global instance resets at 1 AM

Is this intended? Or it should use the timezone of the machine where the core is running?

Branch(es): 3.3.5
TC rev. hash/commit: 7e579a98483313cb68b58dcc1dd0d25903812f93
Operating system: Win 8.1

[Aokromes]

on my case instance reset set to 6 enables reset on 7am.

[Jildor]

You should configure your timezone of the machine for this case

[TheWinchesters]

Configured for my case:
Timezone
(UTC-3:00) Buenos Aires

Adding the difference when configuring worldserver.conf would work but I was wondering if this was intentional.

[illfated]

I use the default setting ( Instance.ResetTimeHour = 4 ) and my resets occur at 03:00 (am). My TZ is GMT+1.

@TheWinchesters : have you checked your auth realmlist.timezone setting?

[Killyana]

Same issue as https://github.com/TrinityCore/TrinityCore/issues/8390

[jackpoz]

Not the same issue as this is about events running serverside while the other issue is about timezone ignored in the packet sent by the client

[jackpoz]

I opened a draft PR https://github.com/TrinityCore/TrinityCore/pull/23540

[jackpoz]

which configs does it affect other than Instance.ResetTimeHour ?

[TheWinchesters]

• Quests.DailyResetTime
• Guild.ResetHour
• Respawn.RestartQuietTime
• Battleground.Random.ResetHour
• weekend xp rate

and not sure about CleanOldMailTime

[jackpoz]

Do all these reset at wrong time ?

[jackpoz]

I tried Guild.ResetHour and it called World::ResetGuildCap() at the right hour of the day

[TheWinchesters]

Oh, sorry. My mistake.

[jackpoz]

could you check the others too and see which ones are broken ?

[TheWinchesters]

This is everything I have experienced so far, (UTC -3):

• It is 23:45 while I am writting this and Darkmon Faire event is not active when it should end at midnight. I checked the same in localhost.
• I just killed a boss now and it says that the instance cd will end in X days, 3 hours. (worldserver config says 6 AM).
• Fishing events during weekend start 3hs sooner.
• Once the server restarted because of Respawn.GuidAlertLevel and it restarted at midnight (worldserver config says 3 AM).
• Sunday , 22:00hs, people complained because the xp rate was normal and it was true. (xp is 2.0 during Friday, Saturday and Sunday)

A easy test for anyone would be entering an instance and see what the welcome message says or wait to see when the Kalu'ak event starts tomorrow.

[jackpoz]

could you check if https://github.com/TrinityCore/TrinityCore/pull/23540 fixes the instance reset ?

[jackpoz]

Updated https://github.com/TrinityCore/TrinityCore/pull/23540 to support Respawn.RestartQuietTime and weekend xp rate too

[jackpoz]

https://github.com/TrinityCore/TrinityCore/pull/23540 fixed some issue

[jackpoz]

which cases are still left to be handled ?

[illfated]

Stranglethorn Fishing Extravaganza is still problematic, isn't it? Or maybe I have forgotten to check if the events occur at a different time than 14:00 local time on Sunday, and whether I could have set a different time deviation somewhere in the config.