Trinitycore: Core/Spells: Spellsteal (Mage)

[TheWinchesters]

Description:
(Spellsteal) https://www.wowhead.com/spell=30449 steals a beneficial magic effect from the target.

Current behaviour:
Some spells as (Arcane Torrent) https://es.wowhead.com/spell=28730 has not a beneficial magic effect if you apply in a enemy

• The debuff that Arcane Torrent applies in the target is shown like you can steal it
• You can use Spellsteal
• You get silenced by the Arcane Torrent effect

Expected behaviour:
You should be able to steal only beneficial magic effects

Steps to reproduce the problem:

1. Create a blood elf mage character
2. .learn all my class
3. .go c id 32666 (A dummy npc)
4. Use Arcane Torrent and Spellsteal on the NPC

Branch: 3.3.5
TC Rev: 7baf5b24525551ddf00c88084edb2a1bafeb758d
OS: Win 8.1 / Debian 9

[Keader]

Arcane Torrent need be negative :/

[TheWinchesters]

This is something that some friends did for me:
https://www.youtube.com/watch?v=hEdaa2DkfEc

It is in spanish, but the spell is Cadenas de hielo = Chains of Ice (https://www.wowhead.com/spell=45524).
They told me that, in the case of this spell, sometimes you can steal it, sometimes you cant.

[Keader]

Looks like you can steal always that boss/ creature has effect immunity
Like slow, was negative in players, but positive in bosses.
IDK what change in spell system that screwup a lot of negative/positive spells

[Riztazz]

Arcane Torrent need be negative :/

https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/SpellInfo.cpp#L3496
This is causing your issue. If spell has energize effect then entire spell will be marked as positive but in case of arcane torrent you have both negative effect and positive effect

[jackpoz]

IDK what change in spell system that screwup a lot of negative/positive spells

usual major rewrite with the author taking a few months of vacation after. makes one want to just revert it altogether

[Riztazz]

Not my place but i disagree, it is open source project afterall and everyone should chip in, not just owner of specific PR but that's my view :P

As far as issue goes, deleting that line i linked earlier will fix the issue and additional effects like silence and so on will be marked as negative per effect and energize effect will be marked as positive

[jackpoz]

could you check which spells will be affected by the change so they can be tested (or checked to see which effects they have) ?

[Riztazz]

SpellId: 28730(Arcane Torrent) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: negative effect |
SpellId: 32724(Gold Team) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |Effect 67 and that effect is currently marked as: positive effect |
SpellId: 32725(Green Team) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |Effect 67 and that effect is currently marked as: positive effect |
SpellId: 35774(Gold Team) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |Effect 67 and that effect is currently marked as: positive effect |
SpellId: 35775(Green Team) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |Effect 67 and that effect is currently marked as: positive effect |
SpellId: 41542(Soul Release) has energize pct effect with additional effects. And those are: Effect 136 and that effect is currently marked as: positive effect |
SpellId: 44321(Mana Rage) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |
SpellId: 51490(Thunderstorm) has energize pct effect with additional effects. And those are: Effect 2 and that effect is currently marked as: negative effect |Effect 98 and that effect is currently marked as: negative effect |
SpellId: 58913(Soul Cleave) has energize pct effect with additional effects. And those are: Effect 98 and that effect is currently marked as: positive effect |Effect 58 and that effect is currently marked as: positive effect |
SpellId: 58919(Consume Minions) has energize pct effect with additional effects. And those are: Effect 136 and that effect is currently marked as: positive effect |Effect 1 and that effect is currently marked as: positive effect |
SpellId: 59156(Thunderstorm) has energize pct effect with additional effects. And those are: Effect 2 and that effect is currently marked as: negative effect |Effect 98 and that effect is currently marked as: negative effect |
SpellId: 59158(Thunderstorm) has energize pct effect with additional effects. And those are: Effect 2 and that effect is currently marked as: negative effect |Effect 98 and that effect is currently marked as: negative effect |
SpellId: 59159(Thunderstorm) has energize pct effect with additional effects. And those are: Effect 2 and that effect is currently marked as: negative effect |Effect 98 and that effect is currently marked as: negative effect |
SpellId: 59507(Thunder) has energize pct effect with additional effects. And those are: Effect 2 and that effect is currently marked as: negative effect |Effect 98 and that effect is currently marked as: negative effect |
SpellId: 62705(Auto-repair) has energize pct effect with additional effects. And those are: Effect 77 and that effect is currently marked as: positive effect |Effect 6 and that effect is currently marked as: positive effect |
SpellId: 64904(Hymn of Hope) has energize pct effect with additional effects. And those are: Effect 6 and that effect is currently marked as: positive effect |

This is a list of spells AFTER that change that has additional effects besides SPELL_EFFECT_ENERGIZE_PCT and that spell is not marked negative by attribute (SPELL_ATTR0_NEGATIVE_1)

If anyone is going to look at it i would check SPELL_EFFECT_HEAL and SPELL_EFFECT_HEAL_PCT, iirc there are cases where heal spell has negative effect as well either on caster or heal victim

edit: If anyone wants to PR it - go ahead. I would rather not since i don't really have much time lately to later review it if anything is wrong, just had one lazy day and figured i'll not waste time

[jackpoz]

I opened a PR with @Riztazz fix https://github.com/TrinityCore/TrinityCore/pull/23992

[jackpoz]

https://github.com/TrinityCore/TrinityCore/pull/23992