Trinitycore: [3.3.5] Icecrown citadel Parent map

[PatricNox]

Description:

Icecrown Citadel's parent map should be Northrend.

Current behaviour:

As of now, players gets ported to their hearthstone location/Dalaran after logging out inside a raid group than later on is disbanded.

Expected behaviour:

The player should appear in Northrend.

Steps to reproduce the problem:

1. Join raidgroup in ICC
2. Logout
3. Disband Raidgroup
4. Login

Branch(es):

Only tested on 3.3.5

TC rev. hash/commit:

TrinityCore rev. b50f35f56bff 2018-09-09 12:45:26 -0300

SQL Contribution to fix explained issue
UPDATEinstance_templateSETparent='571' WHEREmap='631';

[PatricNox]

@Aokromes

some more dungeons in northrend

UPDATE `instance_template` SET `parent`='571' WHERE `map`=632;
UPDATE `instance_template` SET `parent`='571' WHERE `map`=658;
UPDATE `instance_template` SET `parent`='571' WHERE `map`=668;
UPDATE `instance_template` SET `parent`='571' WHERE `map`=724;

[Jildor]

You can do it in one line better ;)

[PatricNox]

Indeed but one liners aren't always the best documentation, as my mum used to tell me :1234:

UPDATEinstance_templateSETparent='571' WHEREmapIN (724, 668, 658, 632, 631);

[illfated]

Tip: if you want to highlight code block syntax, use GitHub Flavored MarkDown: ```sql
example:

UPDATE `instance_template` SET `parent`= 571 WHERE `map` IN (724, 668, 658, 632, 631);

---

edit: and you can always add a comment line on top for documentation:

-- set Northrend as parent map for instances 724, 668, 658, 632, 631
UPDATE `instance_template` SET `parent`= 571 WHERE `map` IN (724, 668, 658, 632, 631);

[Jildor]

Documented 🤣

SET @Northrend         := 571;
SET @TheRubySanctum    := 724;
SET @HallsOfReflection := 668;
SET @PitOfSaron        := 658;
SET @TheForgeofSouls   := 632;
SET @IcecrownCitadel   := 631;
-- set Northrend as parent map
UPDATE `instance_template` SET `parent`=@Northrend WHERE `map` IN (@TheRubySanctum, @HallsOfReflection, @PitOfSaron, @TheForgeofSouls, @IcecrownCitadel);