Trinitycore: Stormwind Royal Guard in Elwynn Forest

[shamage]

Description:

Guardian formation is not correct + walks wrong route.

Current behaviour:

The guards pass through a completely different route, through objects but also in the air.

Expected behaviour:

They should walk according to the exact formation (group) and should walk along the marked path.

Steps to reproduce the problem:

1. Stormwind Royal Guard ( wowhead )
2. walk to the border line between stormwind and evelin forest (before the stormwind entrance) here I start my journey Stormwind Royal Guard
3. look like guards moving off the tracks and completely pushed to themselves
4. in the case of an enemy approach, they must immediately attack - destroy the enemy and then re-group and continue on the road

Branch(es): master

TC rev. hash/commit:

TrinityCore rev. 8391119aa6e5 2018-05-12 19:51:42 +0200 (master branch) (Win64, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.0.2o 27 Mar 2018 (library: OpenSSL 1.0.2o 27 Mar 2018)
Using Boost version: 1.67.0
Using MySQL version: 5.7.21
Using CMake version: 3.11.1
Compiled on: Windows 10.0.16299
Automatic database updates are enabled for the following databases: Auth, Characters, World, Hotfixes
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 900650049 bytes
vmaps directory located in ./vmaps. Total size: 5127494765 bytes
mmaps directory located in ./mmaps. Total size: 6432765196 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 735.00

[shamage]

can anyone help me with this?

[ArcaneFox]

Maybe it's related to https://github.com/TrinityCore/TrinityCore/commit/05fb27dae4e8af859e01e5b9e52b082cba217657

[MrSmite]

Maybe they saw some Earthroot and wanted to level their Herbalism :stuck_out_tongue:

[shamage]

@ArcaneFox - it's possible, but I'm not well enough to handle it myself .
I need to be more experienced than I am

[Ovahlord]

Looks to me that the formation leader is way ahead of the rest of the formation so the other creatures are just trying to keep up. Happens if single formation creatures are not getting loaded at the same time.
On top of that someone might have been lazy with the waypoints and skipped some of them.

[Killyana]

The issue is core side, use ".wp show on" on the leader an you will see it skips some waypoints, also this issue doesn't happen on 4.3.4 with the exact same sql: https://github.com/TrinityCore/TrinityCore/commit/bc974cd2f78f7cd8eda340d89fac557920b0fd76

[shamage]

I have somewhat modified the WP

DELETE FROM `waypoint_data` WHERE `id`=2807910;
INSERT INTO `waypoint_data` (`id`,`point`,`position_x`,`position_y`,`position_z`,`orientation`,`delay`,`move_type`,`action`,`action_chance`,`wpguid`) VALUES
(2807910, 1, -9138.17, 380.201, 90.6534, 0, 0, 0, 0, 100, 460322),
(2807910, 2, -9166.3, 349.528, 86.8937, 0, 0, 0, 0, 100, 460323),
(2807910, 3, -9175.82, 336.321, 83.3663, 0, 0, 0, 0, 100, 460324),
(2807910, 4, -9180.65, 319.038, 79.9215, 0, 0, 0, 0, 100, 460325),
(2807910, 5, -9181.73, 264.124, 74.4053, 0, 0, 0, 0, 100, 460326),
(2807910, 6, -9183.64, 249.003, 73.3792, 0, 0, 0, 0, 100, 460327),
(2807910, 7, -9188.83, 235.514, 72.1262, 0, 0, 0, 0, 100, 460328),
(2807910, 8, -9196.52, 224.821, 71.5789, 0, 0, 0, 0, 100, 460329),
(2807910, 9, -9213.98, 207.762, 69.7115, 0, 0, 0, 0, 100, 460330),
(2807910, 10, -9243.5, 170.799, 67.8722, 0, 0, 0, 0, 100, 460331),
(2807910, 11, -9253.03, 160.325, 67.782, 0, 0, 0, 0, 100, 460332),
(2807910, 12, -9265.69, 154.074, 67.2159, 0, 0, 0, 0, 100, 460333),
(2807910, 13, -9293.82, 148.197, 66.3475, 0, 0, 0, 0, 100, 460334),
(2807910, 14, -9308.14, 141.879, 65.6318, 0, 0, 0, 0, 100, 460335),
(2807910, 15, -9354.13, 114.869, 62.1437, 0, 0, 0, 0, 100, 460336),
(2807910, 16, -9368.56, 108.763, 60.8695, 0, 0, 0, 0, 100, 460337),
(2807910, 17, -9397.22, 98.5408, 58.7155, 0, 0, 0, 0, 100, 460338),
(2807910, 18, -9447.97, 64.5152, 56.1237, 0, 0, 0, 0, 100, 460339),
(2807910, 19, -9481.7, 65.3454, 56.1796, 0, 0, 0, 0, 100, 460340),
(2807910, 20, -9491.29, 61.4076, 55.8961, 0, 0, 0, 0, 100, 460341),
(2807910, 21, -9540.48, -36.426, 56.4425, 0, 0, 0, 0, 100, 0),
(2807910, 22, -9544.38, -48.8436, 56.6936, 0, 0, 0, 0, 100, 0),
(2807910, 23, -9548.15, -75.8307, 57.4422, 0, 0, 0, 0, 100, 0),
(2807910, 24, -9550.16, -116.198, 57.5838, 0, 0, 0, 0, 100, 0),
(2807910, 25, -9552.26, -130.035, 57.4608, 0, 0, 0, 0, 100, 0),
(2807910, 26, -9556.45, -140.017, 57.3353, 0, 0, 0, 0, 100, 0),
(2807910, 27, -9572.33, -158.006, 57.5127, 0, 0, 0, 0, 100, 0),
(2807910, 28, -9578.67, -173.345, 57.3844, 0, 0, 0, 0, 100, 0),
(2807910, 29, -9592.06, -209.808, 57.5509, 0, 0, 0, 0, 100, 0),
(2807910, 30, -9602.84, -238.152, 57.4033, 0, 0, 0, 0, 100, 0),
(2807910, 31, -9614.35, -275.034, 57.6565, 0, 0, 0, 0, 100, 0),
(2807910, 32, -9620.08, -316.316, 57.541, 0, 0, 0, 0, 100, 0),
(2807910, 33, -9618.55, -397.618, 57.8398, 0, 0, 0, 0, 100, 0),
(2807910, 34, -9614.59, -417.262, 57.5388, 0, 0, 0, 0, 100, 0),
(2807910, 35, -9604.18, -445.399, 57.6096, 0, 0, 0, 0, 100, 0),
(2807910, 36, -9592.44, -466.887, 57.7626, 0, 0, 0, 0, 100, 0),
(2807910, 37, -9591.19, -495.533, 57.1896, 0, 0, 0, 0, 100, 0),
(2807910, 38, -9597.22, -509.772, 57.389, 0, 0, 0, 0, 100, 0),
(2807910, 39, -9615.44, -523.8, 55.073, 0, 0, 0, 0, 100, 0),
(2807910, 40, -9617.53, -535.642, 54.4305, 0, 0, 0, 0, 100, 0),
(2807910, 41, -9605.81, -530.37, 55.4642, 0, 0, 0, 0, 100, 0),
(2807910, 42, -9596.4, -511.086, 57.468, 0, 0, 0, 0, 100, 0),
(2807910, 43, -9591.1, -494.595, 57.26, 0, 0, 0, 0, 100, 0),
(2807910, 44, -9592.19, -467.13, 57.7599, 0, 0, 0, 0, 100, 0),
(2807910, 45, -9603.48, -445.435, 57.6334, 0, 0, 0, 0, 100, 0),
(2807910, 46, -9614.39, -417.48, 57.5327, 0, 0, 0, 0, 100, 0),
(2807910, 47, -9618.62, -396.684, 57.8359, 0, 0, 0, 0, 100, 0),
(2807910, 48, -9619.95, -315.623, 57.5263, 0, 0, 0, 0, 100, 0),
(2807910, 49, -9613.89, -275.576, 57.677, 0, 0, 0, 0, 100, 0),
(2807910, 50, -9602.6, -238.762, 57.3921, 0, 0, 0, 0, 100, 0),
(2807910, 51, -9591.68, -209.544, 57.5795, 0, 0, 0, 0, 100, 0),
(2807910, 52, -9578.19, -172.959, 57.4053, 0, 0, 0, 0, 100, 0),
(2807910, 53, -9572.16, -158.882, 57.5609, 0, 0, 0, 0, 100, 0),
(2807910, 54, -9556.99, -140.214, 57.3487, 0, 0, 0, 0, 100, 0),
(2807910, 55, -9551.88, -129.55, 57.4931, 0, 0, 0, 0, 100, 0),
(2807910, 56, -9549.83, -116.194, 57.5861, 0, 0, 0, 0, 100, 0),
(2807910, 57, -9547.77, -75.2292, 57.4717, 0, 0, 0, 0, 100, 0),
(2807910, 58, -9544.15, -48.7211, 56.6931, 0, 0, 0, 0, 100, 0),
(2807910, 59, -9540.13, -36.3305, 56.4429, 0, 0, 0, 0, 100, 0),
(2807910, 60, -9522.54, -0.664641, 55.8888, 0, 0, 0, 0, 100, 0),
(2807910, 61, -9501.11, 43.6223, 56.0809, 0, 0, 0, 0, 100, 0),
(2807910, 62, -9490.82, 61.289, 55.9261, 0, 0, 0, 0, 100, 0),
(2807910, 63, -9481.75, 64.9701, 56.1696, 0, 0, 0, 0, 100, 0),
(2807910, 64, -9448.17, 64.7492, 56.1323, 0, 0, 0, 0, 100, 0),
(2807910, 65, -9397.6, 98.1159, 58.6915, 0,0, 0, 0, 100, 0),
(2807910, 66, -9369.12, 108.678, 60.8266, 0, 0, 0, 0, 100, 0),
(2807910, 67, -9354.42, 114.74, 62.1118, 0, 0, 0, 0, 100, 0),
(2807910, 68, -9308.38, 141.308, 65.5839, 0, 0, 0, 0, 100, 0),
(2807910, 69, -9293.67, 147.971, 66.3295, 0, 0, 0, 0, 100, 0),
(2807910, 70, -9265.99, 153.989, 67.2035, 0, 0, 0, 0, 100, 0),
(2807910, 71, -9253.37, 160.301, 67.7648, 0, 0, 0, 0, 100, 0),
(2807910, 72, -9243.67, 170.79, 67.8746, 0, 0, 0, 0, 100, 0),
(2807910, 73, -9214.37, 207.388, 69.646, 0, 0, 0, 0, 100, 0),
(2807910, 74, -9195.03, 225.991, 71.659, 0, 0, 0, 0, 100, 0),
(2807910, 75, -9188.87, 235.329, 72.1101, 0, 0, 0, 0, 100, 0),
(2807910, 76, -9183.79, 248.639, 73.3513, 0, 0, 0, 0, 100, 0),
(2807910, 77, -9181.57, 263.899, 74.4031, 0, 0, 0, 0, 100, 0),
(2807910, 78, -9175.82, 336.321, 83.3663, 0, 0, 0, 0, 100, 0),
(2807910, 79, -9166.3, 349.528, 86.8937, 0, 0, 0, 0, 100, 0),
(2807910, 80, -9138.17, 380.201, 90.6534, 0, 0, 0, 0, 100, 0),
(2807910, 81, -9134.78, 384.179, 90.6844, 0, 0, 0, 0, 100, 0);

it is necessary that someone else besides me has tested it

if in my effort to contribute a good job I did something wrong please direct me to the right path - thank you

[shamage]

After implementation of WP points, soldiers are already holding their way and attacking enemies.
1.) However, there is a variety of situations when the soldiers do not return to their original position (to be on horseback) but remain without a horse and go on foot any
2.) the leader who leads the group will inevitably leak away from the group right from the start
3.) the good news is that the leader always returns to the horse in every circumstance

[shamage]

here is seen as the leader runs away from the group - the group is still just forming

[shamage]

Here is how the group formed, but the leader continues to run ahead

[shamage]

here it is seen that after the attack the group is formed (without a leader) but no longer horses go on foot

[welder1976]

this smart script

[welder1976]

DELETE FROM smart_scripts WHERE entryorguid=42218 AND source_type=0 AND id>0;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(42218,0,1,0,4,0,100,0,0,0,0,0,28,78855,0,0,0,0,0,1,0,0,0,0,0,0,0,"Stormwind Royal Guard - On aggro - Remove aura"),
(42218,0,2,0,34,0,100,0,2,58,0,0,41,0,0,0,0,0,0,11,42218,30,0,0,0,0,0,"Stormwind Royal Guard - On movement informer - despawn all guars");

[welder1976]

also a similar implementation of this circulation is realized in Northrend in the fortress of the Alliance Borean tundra

[illfated]

Please put ```sql (GitHub MarkDown code block) on a single empty line on top of your SQL code, for easier reading.

[shamage]

DELETE FROM smart_scripts WHERE entryorguid=42218 AND source_type=0 AND id>0;
INSERT INTO smart_scripts (entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment) VALUES
(42218,0,1,0,4,0,100,0,0,0,0,0,28,78855,0,0,0,0,0,1,0,0,0,0,0,0,0,"Stormwind Royal Guard - On aggro - Remove aura"),
(42218,0,2,0,34,0,100,0,2,58,0,0,41,0,0,0,0,0,0,11,42218,30,0,0,0,0,0,"Stormwind Royal Guard - On movement informer - despawn all guars");

@welder1976 :

I tried this script from you, but the suggestion you made did not solve the current issue. I feel as though a script has been incorrectly implemented and the behavior of the group leader with waipoint has incorrect values. But this is purely my consideration.