Trinitycore: Release spirit aggro issue

[Foereaper]

Description:

For some reason, if you release your spirit close to a mob that can aggro onto you, the mob will aggro for a split second and reset. This can be seen easily on boss encounters where you would normally die close to the boss home position. Not necessarily any "negative" issues related to this that I have noticed so far, but definitely not working as intended.

Current behaviour:

When you release spirit, mobs will aggro onto your ghost prior to being teleported to the graveyard.

Expected behaviour:

Mobs should not aggro onto your ghost when releasing.

Steps to reproduce the problem:

1. Die close to a mob that can aggro onto you, easily seen on raid bosses
2. Release spirit while observing creature behaviour from a second account

Branch(es): 3.3.5

TC rev. hash/commit: eb7d22d

TDB version: TDB 335.64

Operating system: Windows Server 2012

[Foereaper]

Literally as I submitted this I was notified by a player that they had a boss maul their corpse while dead earlier today, ie. boss kept attacking after he died. I have not been able to recreate, but figured I should post it in case it is relevant.

[Aokromes]

Try updating to at least 7cff1b540c96d9e2cf82b244cc0d1618bf5b090f

[Foereaper]

Will do as soon as I can, but probably won't be till Saturday, in case someone is able to confirm/deny this by then :)

[Killyana]

Cannot reproduce on rev. 94b5d9bfa119

[Foereaper]

Just tested it on 94b5d9b and it still happens, try it near a boss that has an enter/exit combat yell message, and they'll yell when you release your spirit, tested on a couple different bosses in Naxxramas

[Killyana]

I tested with Lord Marrowgar.

[Foereaper]

https://youtu.be/69xrPaL6uuI

See the yell after the spirit release

[Killyana]

Yes confirm with Instructor Razuvious.

[Foereaper]

I had it happen with Heigan as well

[jackpoz]

@Treeston can you take a look at this ?

[natnat201193]

It seems to me like this is an issue in instances where you get Revived at the graveyard when you release, instead of being changed to a spirit. This is why it happens in naxx and not icc. i have seen this happen with tempest keep also, another instance where you are revived at the graveyard when you release spirit.

[Faq]

@natnat201193 still happens? on what rev?

[natnat201193]

oh i haven't tested it for a long while so im not sure if it does still happen. im just assuming it does seen as this issue has not been closed. ill Retest it and comment again as soon as i have time.

[Aokromes]

This maybe have been fixed by 7bc16e2ee6ace39588a991537ff28811000a16c2

[Treeston]

Very likely this still happens in situations as described by @natnat201193 in previous comment. We revive then teleport later, movement notifies likely happen before reviving.

willfix