Trinitycore: Exotic hunter pet outputs excessive damage [60$]

[Gooyeth]

Description:

The elite/rare pets of the "Exotic beasts" talent have excessive damage.

Current behaviour:

They cause damage from 10k to 20k depending on the player's equipment.

Steps to reproduce the problem:

1. Get the pet "Gondria" (http://www.wowhead.com/npc=33776/gondria)
2. Equip http://www.wowhead.com/item-set=-273/wrathful-gladiators-pursuit y others pieces wrathful
3. Cause damage with the pet

Branch(es): 3.3.5

TC rev. hash/commit: 1acfefb973895b0e3df3c8d9b43b920d2a1b5392

TDB version: TDB 335.63

Operating system: Debian 9

[ghost]

Exotic Beasts in 3.3.5a: https://wow.gamepedia.com/index.php?title=Exotic_Beasts&oldid=2185890

Beast Mastery is the 51 point talent in the Beast Mastery tree of hunters. It allows the hunter to tame exotic beasts and grants four extra skill points to spend in the pet's talent tree.

[ghost]

Not sure if I will get time to test this before the weekend.
Would appreciate if other users can confirm this too,
as well as suggestions for source code references.

[TecDian]

Confirmed. Gondria is the best dd in raid. No icc T10heroic char can compete.^^

[Killyana]

Someone can test the damage with this?
``sql UPDATEcreature_templateSETDamageModifier=4.6 WHEREentry` IN (33776);

[tje3d]

@Killyana works good, now Gondria hits 1k-3k non-crit and 5k-7K crit ( 6.2k gs )

[Jildor]

Pets get damagemodifier? I don't remember that

@ariel- ??

[Keader]

looks wrong to me too lol

[kaldown]

SELECT name, damagemodifier FROM creature_template WHERE type_flags = 65537;

type flags

| name                       | damagemodifier |
+----------------------------+----------------+
| Flesh Eating Worm          |            0.5 |
| Fledgling Chimaera         |              1 |
| Young Chimaera             |              1 |
| Silithid Ravager           |              1 |
| Murk Worm                  |            2.4 |
| Hazzali Sandreaver         |              1 |
| Centipaar Sandreaver       |              1 |
| Chimaera Matriarch         |              1 |
| Devilsaur                  |            2.4 |
| Ironhide Devilsaur         |            2.4 |
| Tyrant Devilsaur           |            2.4 |
| Gorishi Reaver             |              1 |
| Clutchmother Zavas         |              1 |
| King Mosh                  |            4.6 |
| Fledgling Chillwind        |              1 |
| Chillwind Chimaera         |              1 |
| Chillwind Ravager          |              1 |
| Soriid the Devourer        |              1 |
| Haarka the Ravenous        |              1 |
| The Evalcharr              |              1 |
| Mistwing Rogue             |              1 |
| Mistwing Ravager           |              1 |
| Dredge Worm                |              1 |
| Gorishi Hive Guard         |              1 |
| Brumeran                   |              1 |
| Rotting Worm               |            0.5 |
| Earthborer                 |            1.7 |
| Hive'Ashi Sandstalker      |              1 |
| Hive'Zora Reaver           |              1 |
| Hive'Regal Ambusher        |              1 |
| Hive'Regal Hive Lord       |              1 |
| Dredge Striker             |              1 |
| Dredge Crusher             |              1 |
| Rock Borer                 |              1 |
| Rock Worm                  |              1 |
| Deep Borer                 |            2.4 |
| Chimaerok                  |            4.6 |
| Arcane Chimaerok           |            4.6 |
| Chimaerok Devourer         |            4.6 |
| Oozeworm                   |              1 |
| Cadaverous Worm            |              1 |
| Lapress                    |            4.6 |
| Grubthor                   |              1 |
| Xil'xix                    |              1 |
| The Kurken                 |              1 |
| Infernal Hound             |              1 |
| Tyrantus                   |              1 |
| Nuramoc                    |            4.6 |
| Bladewing Bloodletter      |              1 |
| Spawn of Uvuros            |              1 |
| Young Crust Burster        |              1 |
| Vilewing Chimaera          |              1 |
| Ice Heart Jormungar Feeder |              1 |
| Wooly Rhino Bull           |              1 |
| Loque'nahak                |            4.6 |
| Frostwing Chimaera         |              1 |
| Tundra Crawler             |              1 |
| Wooly Rhino Matriarch      |              1 |
| Wooly Rhino Calf           |              1 |
| Hulking Jormungar          |            4.6 |
| Ice Heart Jormungar Spawn  |              1 |
| Shardhorn Rhino            |              1 |
| Snowdrift Jormungar        |              1 |
| Ice Steppe Rhino           |              1 |
| Ravenous Jormungar         |              1 |
| Yggdras Worm               |              1 |
| Infesting Jormungar        |              1 |
| Ravenous Jormungar         |              1 |
| Roaming Jormungar          |              1 |
| Disembodied Jormungar      |              1 |
| Ice Steppe Bull            |              1 |
| Romping Rhino              |              1 |
| Icehorn                    |              1 |
| King Krush                 |            7.5 |
| Tamable Core Hound         |              1 |
| Tamable Chimaera           |              1 |
| Tamable Devilsaur          |              1 |
| Tamable Rhino              |              1 |
| Tamable Silithid           |              1 |
| Tamable Spirit Beast       |              1 |
| Tamable Worm               |              1 |
| Gondria                    |             15 |
| Skoll                      |            7.5 |
| Arcturis                   |            7.5 |
+----------------------------+----------------+

So I wonder, is that only for Gondria ? And how exact amount should be for those creatures after tame beast spell ?
Because it hits hard after tame, but it either hits hard on a wild. I'm not sure if damagemodifier should be 1.0f or any other.

@Jildor @Killyana

select name, damagemodifier from creature_template where entry = 33776;
+---------+----------------+
| name    | damagemodifier |
+---------+----------------+
| Gondria |            999 |
+---------+----------------+

select name, damagemodifier from creature_template where entry = 33776;
+---------+----------------+
| name    | damagemodifier |
+---------+----------------+
| Gondria |            1   |
+---------+----------------+

[Killyana]

Pets musn't use damage modifier from the original on creature_template, it must be fixed.

[kaldown]

@Killyana when you say "pet" you mean a creature that already tamed? For instance. This particular creature hits a lot while not tamed, but after successful taming creature damage should be fixed to what? I asked this right in my prev. post.
if use 4.6f by default, Gondria hits for 2k (non crit). if 1.0f -> 150. So which walue should be default after taming, or I didn't understand you right?

[Killyana]

I don't know, but I'm certain the damage modifier musn't be used. A core dev will check this.

[ariel-]

I'm not quite sure of that, what is the point to have a exotic pet if it doesn't out-dps the normal pets?, somehow they must manage to have different damage

[Shauren]

The point of exotic pets is their abilities, not damage (bloodlust for example)

[MrSmite]

I'm not quite sure of that, what is the point to have a exotic pet if it doesn't out-dps the normal pets?, somehow they must manage to have different damage

All pets are normalized after they're tamed. The only benefit to exotic pets are their skins and special abilities. While not official blue posts, here are some discussions that support this statement:

http://forums.wow-petopia.com/viewtopic.php?t=2006&p=41725#p41700
https://eu.battle.net/forums/en/wow/topic/8715772582#post-3
https://us.battle.net/forums/en/wow/topic/2267592068#post-2
https://eu.battle.net/forums/en/wow/topic/17613041167#post-2

[kaldown]

So what to do after all?

All pets are normalized after they're tamed.
or it must be?
Is Gondria damage normalized beforeafter taming?

[MrSmite]

So what to do after all?

If they're using damage modifier then that is not considered 'blizzlike' and should be fixed.

[tje3d]

Any hackfix or update on this?

[kaldown]

I tried, but didn't understand what to do.
some said it's normal, some said not - what is a right ratio?

[tje3d]

@kaldown same here, idk where to start. But i'm sure this is not normal.

[TecDian]

Of course it is not normal. Pets should have normalised damage according to their pet family - wolves, cats, spirit beasts, bugs, worms, etc.. Additionally, there should be differences in damage for normal and elite, making Goremaw the pet with the highest damage.
Gondria for instance is a spirit beast, it doesn't count as a cat. Thus it should do only medium damage.

Now TC uses the damage of the wild animals to calculate the damage of the pets. But there should be an extra table or formula to calculate the damage of all those pet families according to level and normal/elite.

You may look here for a general overview: https://huntsmanslodge.com/garsnotes-best-dps-pets/
You may also find this old WotLK version of petopia useful: http://web.archive.org/web/20100323204924/http://www.wow-petopia.com/

[illfated]

I haven't checked values or combat logs, but I noticed mostly during the last 4 weeks (playing alone as a level 80 hunter on 3.3.5) that other spirit beasts behave much the same way as Gondria (I tamed Skoll + Loque'nahak in addition to Gondria) and found that I had to pay attention and at least get some shots in to avoid losing loot when they killed normal hostile NPCs too fast (usually when I fought more than 1 normal mob). I still subscribe to what was said in https://github.com/TrinityCore/TrinityCore/issues/21333#issuecomment-365139109 😄

[Tatara902]

The main issue here is that pets inherit the damage of the tamed beast (DamageMod in DB), this bug happens when you tame a elite creature from anywhere, however the highest level of the creature the highest damagemod in db so if you want a pet with a lot of damage you can tame a pet from a dungeon/raid or northern zone.

[MrSmite]

But there should be an extra table or formula to calculate the damage of all those pet families according to level and normal/elite.

This is not correct:

https://wow.gamepedia.com/Patch_3.1.0
Cunning, Ferocity and Tenacity pets now all have +5% damage, +5% armor and +5% health bonuses. This should make more pet families feel viable, while additional talents have been added to distinguish a pet’s abilities based on its specializations.

So it doesn't matter wether the pet is a cat, bear, boar or strider. Nor does it matter if it is elite, normal or exotic. Yes, the way Trinity does it is wrong but that's mainly because nobody could get a proper table built by sniffing to see what the pets had on retail when tamed and of course it's pointless now.

I suppose someone could make up a table and see what happens. If what we're doing now is OP and non-blizzlike then cerainly a non-blizzlike table that attempts to fix it could work. At least that way we'd have a better way to tweak the stats of they go too far in either direction.

[Aokromes]

Maybe after https://github.com/TrinityCore/TrinityCore/commit/743980a6255a222827d4cc8555eccb14192cb260 it can be fixed properly.

[Keader]

i dont think so...
Need spell scale system xD

[MrSmite]

I think the issue is nobody knows what the baseline of the tamed pet should be. It's true that untamed animals have varying stats based on family (eg: a level 20 cat has higher AGI / DMG but lower HP than a level 20 bear) but when they're tamed, they're supposed to all be normalized... but to what?

One of the classic examples is Broken Tooth, a level 37 cat from the Badlands. Prior to normalization it had a tamed attack speed of 1.0 (which no other level 37 cat had) but after normalization its attack speed was adjusted to 2.0 just like bears, boars and everything else.

I guess in that regard it's simple enough to make all tamed pets have a base 2.0 attack speed but that doesn't help with HP, AGI, etc. We simply don't know what the base values are per level.

[Jildor]

Can be caused by this commit?
f1986c6aafdf2457902a7a4cc7acc903cbbdc7bb

[jerbookins]

Just a little bit of anecdotal evidence to support that Exotic pets are in fact OP AF 🔥

[G] [Archimonda]: Recount - DPS for Last Fight
[G] [Archimonda]: 1. Bitey <Archimonda> 1688.6 (77.3%)
[G] [Archimonda]: 2. Archimonda 495.4 (22.6%)(edited)
[G] [Archimonda]: Recount - Damage Done for Last Fight
[G] [Archimonda]: 1. Bitey <Archimonda> 98412 (1688.6, 77.3%)
[G] [Archimonda]: 2. Archimonda 28773 (495.5, 22.6%)

Solo killed Durn the Hungerer 67+ (probably could have just let my pet do it to be perfectly honest).
127,185 hp in 58 seconds as a 67 hunter using Devilsaur with Heirloom gear and double talent points (maxed out bm, half way into marksman).

Just as a side note, because this hunter is literally the first hunter I've ever made in Warcraft, I don't know if hunter pets are supposed to be able to use more than just the 4 skill slots in the pet bar but the pets are definitely using all of their available skills even those NOT pinned to the pet bar.

c5fa08afc1d1

[MrSmite]

Just as a side note, because this hunter is literally the first hunter I've ever made in Warcraft, I don't know if hunter pets are supposed to be able to use more than just the 4 skill slots in the pet bar but the pets are definitely using all of their available skills even those NOT pinned to the pet bar.

I played a Hunter almost exclusively on retail back in TBC/WotLK and can say without a doubt that pets are not supposed to use skills that are not on their hotbar. There are obviously skills in the Beastmastery tree but those are activated by the player so shouldn't be auto-casting.

Now for the caveat... on retail, there was a bug (which was fixed) where pet skills in the spellbook retained their auto-cast state, most notably Cower. Naturally, this caused a crap ton of problems with aggro so I would suggest looking at wether Trinity has somehow replicated this bug. Of course it could also be a talent being applied incorrectly, or both.

[jerbookins]

In the video you can see that Call of the Wild, Rabid, Monstrous Bite, and Bite are on the pet spellbar and that it is using both Cower and Dash with autocast on.

https://streamable.com/1xp4b

[MrSmite]

Yep, that's the bug I was talking about.

But it also appears your pet spells are ignoring their focus requirements and cooldowns. In the beginning, Monstrous Bite appears to fire 3 times before the cooldown appears, and Bite has a 25 focus requirement and even with 2 points in Bestial Dicipline, you would't generate focus fast enough for it to fire without any delay.

[ciber96]

I can confirm this is still an issue. On our server we made a hackfix that normalized basic damage, but critic damage scales up to 20k. We had to disable exotic pets for now.

[ciber96]

I can confirm this commit broke pets damage: https://github.com/TrinityCore/TrinityCore/commit/f1986c6aafdf2457902a7a4cc7acc903cbbdc7bb

We reverted it on our server and now pets are back to normal.

[jerbookins]

@ciber96 so when you say

pets are back to normal

do you mean that they are unchanged or did commit f1986c6 normalize all pets as they should be?

[illfated]

I read his comment to mean that the pet damage is normalized after reverting that specific commit.

[Aokromes]

added 60$ here

[jackpoz]

A PR has been opened at https://github.com/TrinityCore/TrinityCore/pull/23403 . Please give it a try and report feedback there

[ariel-]

3d7166c1c78e0e0011af840b76f3f5a8ccccaaa0 was a followup to f1986c6aafdf2457902a7a4cc7acc903cbbdc7bb. Can't recall whether Pets inherited from Creature, but this was done before.

[jackpoz]

So this doesn't happen anymore on clean TC 335 ?