Trinitycore: [7.3.2] Connection Patcher Pattern not found

[Rudi9719]

Description:

The connection patcher fails on macOS High Sierra.

Current behaviour:

Creating patched binary...
Determined build number: 25549
Mac client...
patching Portal
Found offset 22407760
patching redirect RSA Modulus
Found offset 22383056
patching BNet certificate file location
Found offset 22997491
patching BNet certificate file to load from local path instead of CASC
Found offset 2437579
patching BNet certificate file signature check
EX: unable to find pattern
An error occurred. Press ENTER to continue... 

Expected behaviour:

The client should patch.

Steps to reproduce the problem:

1. Pull the 7.3.2 branch
2. Build with tools
3. Copy all tools to the World of Warcraft directory
4. Run client patcher with --path to your WoW binary.

Branch(es):

7.3.2

TC rev. hash/commit:

commit 55350b1 (HEAD -> master, origin/7.3.2, origin/HEAD)

TDB version: N/A

Operating system: macOS High Sierra (10.13.2)

[TrinityCoreBot]

This issue is not considered valid because of the following reasons:

• No proper commit hash (revision)

Please read http://bit.ly/tc-issuetracker-and-you and add the missing information to this issue. Thanks.

[mdX7]

7.3.2 is not fully supported yet and requires an in memory patcher (=launcher) instead of the filepatcher you used. Afaik that is also in that branch. But not sure if mac is supported yet tho

[Shauren]

@mdX7 not for mac. that one still uses file patcher

[mdX7]

Yea. Forgot that mac binaries are non obfuscated

[Nupper]

7.3.2 launcher dose not work currently due to some internal errors.. while 7.3.2 isn't fully supported...trinitycore will update it when they feel its ready.

[Shauren]

Fixed in master branch