Trinitycore: [3.3.5] DB/Gossip: fix gossip text for some NPCs in Western Plaguelands

[Wyreth]

Description:

A few questgivers in Western Plaguelands' Horde and Alliance camps had missing conditions for their gossip texts.

One of them had a BroadcastText that was changed in Cataclysm or beyond, making it invalid for 3.3.5.

Branch(es): 3.3.5

TC rev. hash/commit: 1af6df4

TDB version: 335.63

Suggested fix:

UPDATE `npc_text` SET `BroadcastTextID0`=0 WHERE `ID`=3753;
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=14 AND `SourceGroup` IN (3223, 3183, 3228, 3184, 7385);
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorType`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES
(14, 3223, 3978, 0, 0, 8, 0, 5230, 0, 0, 1, 0, 0, "", "Gossip text requires quest 'Return to the Bulwark' NOT rewarded"),
(14, 3223, 3979, 0, 0, 8, 0, 5230, 0, 0, 0, 0, 0, "", "Gossip text requires quest 'Return to the Bulwark' rewarded"),
(14, 3183, 3939, 0, 0, 8, 0, 5230, 0, 0, 1, 0, 0, "", "Gossip text requires quest 'Return to the Bulwark' NOT rewarded"),
(14, 3183, 4040, 0, 0, 8, 0, 5230, 0, 0, 0, 0, 0, "", "Gossip text requires quest 'Return to the Bulwark' rewarded"),
(14, 3228, 3984, 0, 0, 8, 0, 5217, 0, 0, 1, 0, 0, "", "Gossip text requires quest 'Return to Chillwind Camp' NOT rewarded"),
(14, 3228, 3985, 0, 0, 8, 0, 5217, 0, 0, 0, 0, 0, "", "Gossip text requires quest 'Return to Chillwind Camp' rewarded"),
(14, 3184, 3940, 0, 0, 8, 0, 5217, 0, 0, 1, 0, 0, "", "Gossip text requires quest 'Return to Chillwind Camp' NOT rewarded"),
(14, 3184, 4039, 0, 0, 8, 0, 5217, 0, 0, 0, 0, 0, "", "Gossip text requires quest 'Return to Chillwind Camp' rewarded"),
(14, 7385, 8846, 0, 0, 47, 0, 9474, 65, 0, 0, 0, 0, "", "Gossip text requires quest 'The Mark of the Lightbringer' rewarded or not taken"),
(14, 7385, 8964, 0, 0, 47, 0, 9474, 10, 0, 0, 0, 0, "", "Gossip text requires quest 'The Mark of the Lightbringer' taken or completed");

[Killyana]

BroadcastTextID0=0 ?

[offl]

One of them had a BroadcastText that was changed in Cataclysm or beyond, making it invalid for 3.3.5.

[Wyreth]

Aye. It was changed after WotLK (strangely, only the Horde one. The Alliance one was untouched). So keeping that broadcast text id makes the wrong text display. The text currently in npc_text is the right one :P

broadcast_text is great, but it's not a panacea. Some texts were reused by Blizzard when they rehauled the old world, so they're only valid for Cataclysm and beyond. There are probably other cases where the text in npc_text is right but the one in broadcast_text is wrong.

[Killyana]

broadcast_text: -- Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there.
npc_text: -- Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so.

the extra part: "especially as we push towards Andorhal and whatever malign force that controls the Scourge there." Doesn't match with the storyline ?

[Wyreth]

That extra part was present in WotLK (check here for proof). The Alliance NPC still has it, too. Just the Horde one has that extra part missing in broadcast_text.

You inverted the two, by the way :P

broadcast_text has "Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so."

npc_text has "Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there."

For reference, the Alliance broadcast_text has "Welcome to the front lines, $c. The Kingdom of Stormwind, with the aid of its allies, has sent me here to counter the growing threat of the Scourge. Here at Chillwind Camp, we fight for our continued survival on a daily basis.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there."

That one is correct. But it's only valid for Alliance.

[Killyana]

So it's fine just update the npc_text using the one from broadcast_text

[Wyreth]

Sadly not. The broadcast_text for Horde doesn't have the ".. especially as we push towards Andorhal and whatever malign force that controls the Scourge there." part. It was there in WotLK.

The npc_text is the correct version.

[Killyana]

Can you link?:
Horde: npc_text ID=, broadcast_text id=
Alliance: npc_text ID=, broadcast_text id=

[Wyreth]

Horde:

• Broadcast Text ID: 6229

• Content: "Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so."

• npc_text ID: 3753

• Content: "Welcome to the front lines, $c. While politicians may connive and scheme amongst themselves, they'll find no such luxury afforded to them here. This is the Bulwark, and we fight for our continued survival on a daily basis here.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there."

Alliance:

• Broadcast Text ID: 6230
• Content: "Welcome to the front lines, $c. The Kingdom of Stormwind, with the aid of its allies, has sent me here to counter the growing threat of the Scourge. Here at Chillwind Camp, we fight for our continued survival on a daily basis.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there."

• npc_text ID: 3754.
• Content: "Welcome to the front lines, $c. The Kingdom of Stormwind, with the aid of its allies, has sent me here to counter the growing threat of the Scourge. Here at Chillwind Camp, we fight for our continued survival on a daily basis.$B$BIf you've come here looking for a chance to prove yourself as a hero, then you'll find plenty of opportunities to do so... especially as we push towards Andorhal and whatever malign force that controls the Scourge there."

[Wyreth]

Wrong button, sorry.

[Killyana]

Ok.

[ZenoX92]

I already had posted a fix for some of these NPCs' gossip texts ( #20522, #20523) but your fix seems better than mine. Seems also I set the wrong quest in the conditions. (I used quest "Mission Accomplished!").

[Wyreth]

Didn't see that, or I'd have posted in your issue report. Sorry :P

Yeah, just found out how it works from an old video.

Gossip for alchemist and priest changes after the first "return to camp" quest. Gossip options for the cauldrons are unlocked gradually.

It's all part of a zone-wide event where many people have to complete the cauldron quests. Misison Accomplished! is the reward for "winning" this event. I doubt we have enough data available to fix it all. I'm fixing the other involved gossip options right now.

Unrelated to this issue, found a gossip text that's probably used for server issues: "We are having difficulty determining the status of the plague within the area; check back shortly and we may have a better idea." :D

[ghost]

Good job, nice detective work. Thank you for the continued contribution! 👍
(adding labels to this issue even though it is closed, for archival clarity)