Trinitycore: [335] - mail_items not deleted when expire (after return)

[Jildor]

Description:

When mail with items is returned and expire_time ends, the mail is deleted, but mail_items and items in item_instance still in the DB
You can see all mail_items without mail in DB:

SELECT * FROM `mail_items` WHERE `mail_id` NOT IN (SELECT `id` FROM `mail`);

Steps to reproduce the problem:

1. Send a mail with items
2. Wait expire_time ends and mail is returned
3. Wait expire_time ends and mail is deleted
   (you can update the expire_time and restart server for make faster the process)

Branch(es): 3.3.5

TC rev. hash/commit: 445c5a00e8

TDB version: TDB335.63

Operating system: Debian

[Vincent-Michael]

try pls:

https://gist.github.com/Vincent-Michael/4edc5b3aa07c0b8eb670424d6dc8b371

[Jildor]

@Vincent-Michael no!
Then items in item_instance still and...not is a good idea xD

Edit: I see you edit gist, I will try it tomorrow

[Jildor]

Tested and works fine @Vincent-Michael 👍

[qyh214]

Thanks!

[ccrs]

@Vincent-Michael time to commit :dancer:

[Jildor]

C'mon @Vincent-Michael 💃

[ghost]

Unless he uses private repositories, it looks like he doesn't have a repository to push from.
I am thinking maybe one of us could just create a PR and let V-M merge it if he wants to.