Trinitycore: [3.3.5] Scripts/IcecrownCitadel: Sister Svalna can not resurrect captains

[shenhuyong]

Description: Sister Svalna can not resurrect captains and break the event. It seems Sister Svalna enter evade mode before do ACTION_RESURRECT_CAPTAINS, the evade mode call a reset() and change the _isEventInProgress to false, then UpdateAI() always returns on first line and it can not do EVENT_SVALNA_RESURRECT.

It works fine before commit e2a1ccd118d129b96e09ff1a15ed0adb1d4a3897

If I add this line void EnterEvadeMode(EvadeReason why) override { if (_isEventInProgress) return; ScriptedAI::EnterEvadeMode(why); } on line 821 can fix this problem.

Expected behaviour: Sister Svalna shouldn't enter evade mode when event in progress.
Branch(es): 3.3.5
TC rev. hash/commit: 07593f6c3488666423093c2c32514a0a378da942
TDB version: TDB 335.63
Operating system: Windows 10

[Keader]

@Treeston

[qyh214]

according to shenhuyong‘s fix ,it works and seems well

[ghost]

OK, if I have understood it correctly, what you are suggesting is this:

diff --git a/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp b/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
index 59a95ae0b9..b8840d502c 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp
@@ -819,6 +819,12 @@ class boss_sister_svalna : public CreatureScript
                 }
             }

+            void EnterEvadeMode(EvadeReason why) override 
+            {
+                if (_isEventInProgress) return;
+                ScriptedAI::EnterEvadeMode(why);
+            }
+
             void JustReachedHome() override
             {
                 _JustReachedHome();

(feel free to tell me if I got any of it wrong)

---

edit: this is based on current 3.3.5 content in
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Northrend/IcecrownCitadel/icecrown_citadel.cpp#L820-L856

[Noryad]

@shenhuyong that code works ok for me, tested on 98c3631

[qyh214]

@tkrokli I think his means is that and I have test in game,works ok for me

[ghost]

OK, thank you for the feedback, nice to know.

@shenhuyong : Would you like to create a Pull Request for your suggested fix?

[Keader]

But what happens when you wipe during event?

[ghost]

Good question. All of you who already tested the code change, please test that too.

[Noryad]

Nothing strange happens, just the fight begins. Should I observe something specific?

[ghost]

Well, since this issue is about Sister Svalna entering evade mode and not being able to resurrect captains, I guess it would be useful to know if anything unexpected happens, like if the instance can't be resumed like you would do on a retail server after a wipe. Reports of any bug observed as direct result of that code change is helpful to determine if it can be added to the TC source (although a Pull Request would definitely call for feedback).

[kvipka]

https://www.youtube.com/watch?v=4cNtREls3CQ

it should working like this?

[Noryad]

@tkrokli the patch allows Sister Svalna to resurrect the captains and enter combat, After a wipe, Sister Svalna remains in combat. Tested in game on e19bb7a . The problem is that the captains must join the fight to help her but they do not.
http://wowwiki.wikia.com/wiki/Sister_Svalna

... When the battle against Svalna herself begins, she will resurrect two of the slain captains as Scourge to aid her in combat.

[ghost]

Thank you for the feedback. That means we need some more code to have a complete fix. Since I'm not a real coder, I would like suggestions for the remaining bit from anyone with real coding skills.

[Noryad]

@sirikfoll can you take a look please?

[Keader]

https://github.com/TrinityCore/TrinityCore/issues/19985#issuecomment-334063792 cant be used, because can have wipes when "event is in progress" :)
It's caused by Thread Rewrite, because i changed some stuffs in Svalna before this commit and was working.
Need find why thread rewrite broken it and fix, prevent Svalna enter in evade is not a solution.

[Noryad]

@Keader i remember that you solved it once but now the problem is another :(

[Keader]

Yes, new issue appear after threat rewrite
i will try take a look and find why she's enter in evade now =x

[Treeston]

work on #19930 has resumed, it was given merge priority over #18771

might be worth investigating on that branch instead

[Keader]

yay xD

[Exodius]

So... Does 1eb2aef1791df5942b3760162d5180cb0bdb51ec fix this issue?

[nerc0487]

The existing issues at the moment are the following:

1-Crok stands idle and does not attack Svalna

2-Svalna acts as a yellow-factioned npc (instead of red) if wiped on, she won't engage nearby players unless players engage her first

3-Svalna revives 2 champions that are summoned in the previous hall (standing idle) until a party member manually runs back there to pull them. The risen champions are supposed to automatically run towards the group after they're revived.

[Highest Priority] 4-Svalna's casted spear on a player's corpse (visual). It cannot be seen when the player is impaled on the ground. When a player attempts to remove the spear from the impaled player's corpse lying on the ground, the player attempting to remove it does not collect the spear. In addition, the interactive icon is a vehicle "enter" icon as opposed to a cog wheel "activate" icon.
If players are not able to debuff the implafe aura off their party & throw the spear back at Svala the boss would not be doable, since her immunity shield will stand.

Here's the encounter: https://www.youtube.com/watch?v=dYXY7QsAI98
Fast-foward to 5:00 to check the correct impale behavior on the far left hand side of the screen impaling the caster at exactly 5:05.
The spear is also horizontal, when it should be vertical as shown in the video.