Trinitycore: [master] Death Knight starting zone

[ArcaneFox]

Description:

Phasing isn't working correctly in the death knight starting zone.

Current behaviour:

CHANGEME Tell us what happens.
If this is a crash, post the crashlog (upload to https://gist.github.com/).

Expected behaviour:

CHANGEME Tell us what should happen instead.

Steps to reproduce the problem:

1. Create a new DK

Branch(es): master

TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/3b6fb1c4313881da84f23e1607ef5f700814afe1

TDB version: 720.00 + updates

Operating system: Windows 10 64-bit

[ghost]

Your description could do with some improvement, hard to know what the issue looks like without more info, like NPC names/IDs/links and some text about what you see vs what is expected. Leaving out parts of the template is usually not a good thing. Maybe you could add a screenshot to show what you're referring to? (Sure, we know that the phasing is not good enough in master, but issue pages can always do better with some more relevant info.)

---

(edit) I added back the missing template sections Current behaviour: and Expected behaviour:

[ArcaneFox]

Sorry but I can't describe this with words, so I made some screenshots.

[ghost]

Oh. Right. 😆 Everything is happening at once. There is no divide between the phases, so all phased creatures show up in the default phase. :-p

---

(edit) I guess that the zone scripts need to be updated to fix the phasing so the creatures are separated.

[ccrs]

.gm off works like a charm

[ghost]

Aha.... should have thought about that scenario.

---

@ArcaneFox : try again with .gm off and report back with your results.

[Aokromes]

better, try a non-gm account.

[ArcaneFox]

I tried with a non gm account but there are no changes.

[ghost]

better, try a non-gm account.

Not have sense, if table creature have PhaseId = 0, non-gm account not help.

@ArcaneFox
Check creature_table column PhaseId.

Gm account allowed see creature's, even if PhaseId =0.
Gm account set player in phase = 2147000000. This is allow see creature in any phases.

[ArcaneFox]

http://www.wowhead.com/npc=29110/the-lich-king

guid,id,map,zoneId,areaId,spawnMask,PhaseId,PhaseGroup,modelid,equipment_id,position_x,position_y,position_z,orientation,spawntimesecs,spawndist,currentwaypoint,curhealth,curmana,MovementType,npcflag,unit_flags,dynamicflags,ScriptName,VerifiedBuild
130896,29110,609,0,0,1,0,0,0,0,2310.27,-5742.21,161.207,3.85718,360,0,0,27890000,0,0,0,0,0,,0

[ghost]

PhaseId and PhaseGroup Empty.
Death Knight have phase spells in spell_area.
Also in Cataclysm phasing system changed. On Pandaria, Draenor and Legion phase system extended.
Need add entry in creature table for working. Black job.

[MrSmite]

better, try a non-gm account.

But honestly, a gm account with gm off should behave just like a regular account, otherwise a GM cannot ever see what a player sees without account hopping.

[Palabola]

Old PhaseValues(Pre-WoD) can be converted to PhaseGroups.

Here is my solution in PHP, not every Bitmasked Phase got equal PhaseGroup those need to be solved.

https://pastebin.com/gG7QDsSR