Trinitycore: [3.3.5] CRASH - ACCESS_VIOLATION

[Noryad]

Current behaviour:
https://gist.github.com/Noryad/eaf0ec76f5f2bb0c8e8e6bb997d439d4

Branch(es): 3.3.5

TC rev. hash/commit: 7de5bef

TrinityCore rev. 7de5befbc39c+ 2017-02-27 14:38:00 -0300 (master branch) (Win32, RelWithDebInfo, Static) (worldserver-daemon) ready...

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

[ariel-]

https://github.com/TrinityCore/TrinityCore/commit/7de5befbc39cd6bf45166fd2c5d0532065f7e99e is not master branch commit

[Noryad]

Because my cloned repository had 3.3.5 as master branch some time ago, currently i just keep updating from 3.3.5 branch but my local branch retains the master name.

[ariel-]

Do you have any repro steps?

[jackpoz]

spell_sindragosa_s_fury_SpellScript::FilterTargets
spellID = 70598
m_positionX = 4758.284180
m_positionY = 2483.861328
m_positionZ = 277.881714
m_orientation = 3.139089
m_mapId = 631
m_name = "Sindragosa"

https://github.com/TrinityCore/TrinityCore/blob/7de5befbc39cd6bf45166fd2c5d0532065f7e99e/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp#L1098

return obj->ToPlayer()->IsGameMaster();

Usual script code quality, don't cast and dereference, either NULL check or ASSERT

[Shauren]

Hey, the script quality in ICC was amazing before other people touched them

[Jildor]

@ariel-
I think the crash persists

Crashlog: https://gist.github.com/Jildor/c0137d9643cc6d95504f60bdbb3b2736

TC rev. hash/commit: c296d255e25a2d0eb7155f64eea32cc36fed280a

TDB version: TDB335.63

Operating system: Debian

[Keader]

In clean trinity i cant reproduce it @Jildor
You know any way?!
Btw, i have this crash in a server that i contribute... but core is not clean

[Jildor]

I do not know how to reproduce it :(