Trinitycore: Mr. Smite pulls more adds than intended

Created on 19 Feb 2017 · 12Comments · Source: TrinityCore/TrinityCore

Description:
Pulling Mr. Smite anywhere agros more than just pirates. Starting the fight agroes a few of the pirates standing behind him.

He should not be pulling the pirates behind him.

Branch(es):
3.3.5

TC rev. hash/commit:
76f3e0edea88 2017-02-18 11:36:02 +0100 (3.3.5 branch) (Win64, Release, Static)

TDB version:
335.62

Operating system:
Windows 10 Server & Client

Branch-3.3.5a

Source

jerbookins

Most helpful comment

Pulling Mr. Smite anywhere aggros more than just pirates ;)

Anyway, I can confirm this behavior on a slightly older core too. I'm not sure if it's a linking issue or if I need to have my faction changed so the pirates won't assist. They're always in the way anyway.

Lapdogs! All of them...

MrSmite on 19 Feb 2017

😄9

All 12 comments

Pulling Mr. Smite anywhere aggros more than just pirates ;)

Lapdogs! All of them...

MrSmite on 19 Feb 2017

😄9

@MrSmite: Control your damn adds!

ariel- on 20 Feb 2017

😄3

Control your damn adds!

I know, right! I yelled at them to check out that noise and they just stand around stroking their parrots! I guess they didn't understand when I said Avast, ye swabs! Repel the invaders that I meant __RIGHT NOW!__

I'll have to improvise.

MrSmite on 21 Feb 2017

👍3 😄2

me->SetNoCallAssistance(true);

offl on 18 Dec 2017

This is being caused by chain aggro not being like it is in retail (i.e. a simple radius rather than continuing chain from npc to npc). The pirates are sufficiently distant that they shouldn't be pulled automatically.

Teppic1 on 18 Dec 2017

Here's a video of what looks like BC live server footage of a 41 paladin killing Mr. Smite. No additional pirates are pulled.

https://www.youtube.com/watch?v=OS54uMVd1iU

In b9b667f9253c when Smite is pulled by you attacking the stealthed pirates at the bottom of the ramp, he pulls the two extra pirates behind him.

jerbookins on 19 Dec 2017

In the current HEAD db of 335 making it up that ramp after smite is tough, you can easily pull the whole side with Cookie if you carelessly walk up the ramp at level.

The whole boat has aggro issues like this, the pirates come off the upper scaffolding when you pass under it, pulling the guys on the ramp and the base of the ramp. It's a train wreck to fight all that at level.

I realize this was a bit of thing in retail as well, perhaps its the parrots being pre summoned and they make the aggro "bloom".

The speed at which pirates flee ... whoa, Deadmines is aptly named.

gmillerd on 19 Dec 2017

Reduce assistance radius to 5 yards (approximate retail value) and he won't pull the pirates. The default in TC is too high (10 I think) to compensate for no chaining of assistance.

Teppic1 on 19 Dec 2017

👍1

Another way https://github.com/cmangos/tbc-db/commit/a5887777dfcd63689e9e2ae2add6cb11a28d7826
But focus on this comment:

Aggro Linking is done in creature_linking, callforassist pulse chainpulls other nonrelated mobs

If Mr. Smite must be in formation with some NPCs, then the issue must be fixed by making all creatures in formations stop call for assistance on aggro. Because from my expirience sometimes some formations(MGTR) are close to each other but can be pulled separately.
So in future it is not about a new extra flag. You can't add it to all creatures. Simply because sometimes it will make some formations behavior non-blizzlike.

One formation can still aggro another formation by accident if creatures from one formation are already in combat(creature was feared into another pack).
Single creatures with waypoint almost always are without formations and can be single-pulled.

offl on 29 Mar 2020

This is the current formations:

DELETE FROM `creature_formations` WHERE `memberGUID` IN (79337,79330,79338,79345,79346);
INSERT INTO `creature_formations` (`leaderGUID`,`memberGUID`,`dist`,`angle`,`groupAI`, `point_1`, `point_2`) VALUES
-- Mr Smith and the 2 Defias Blackguard in front
(79337, 79337, 0, 0, 515, 0, 0),
(79337, 79345, 0, 0, 515, 0, 0),
(79337, 79346, 0, 0, 515, 0, 0),
-- The 2 pirates behind
(79338, 79338, 0, 0, 515, 0, 0),
(79338, 79330, 0, 0, 515, 0, 0);

I tried putting all this spawns in the same AI with no assist when the boss aggro, but still callforassist is called for the 2 spawns behind him.

Also the position of this 2 pirates is wrong (probably like all spawn in this instance) they must be much closer.

(@CGUID+307, 657, 36, 1581, 0, 3, 1, 0, 0, 0, -28.81776, -795.674, 19.39633, 6.021386, 7200, 0, 0, 0, 0, 0, 0, 0, 0, 11159), -- 657 (Area: 0 - Difficulty: 0)
(@CGUID+309, 657, 36, 1581, 0, 3, 1, 0, 0, 0, -21.87397, -802.9406, 19.76329, 1.727876, 7200, 0, 0, 0, 0, 0, 0, 0, 0, 11159), -- 657 (Area: 0 - Difficulty: 0)