Trinitycore: [3.3.5] Spell/Warlock: Improved Drain Soul not work properly

[Noryad]

Description:
http://wotlk.openwow.com/spell=18372

Improved Drain Soul (Rank 2): Returns 15% of your maximum mana if the target is killed by you while you drain its soul. In addition, your Affliction spells generate 20% less threat.

Current behaviour:
Improved Drain Soul not returning a % of your maximum mana.

Expected behaviour:
Improved Drain Soul should return a % of your maximum mana.

Steps to reproduce the problem:

1. Kill a target under effects of Drain Soul.
2. No mana gain.

Branch(es): 3.3.5

TC rev. hash/commit: c6060dd

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

[Noryad]

Fix

-- Drain Soul
DELETE FROM `spell_proc` WHERE `SpellId`=-1120;
INSERT INTO `spell_proc` (`SpellId`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `ProcFlags`, `SpellTypeMask`, `SpellPhaseMask`, `HitMask`, `AttributesMask`, `ProcsPerMinute`, `Chance`, `Cooldown`, `Charges`) VALUES
(-1120, 0, 0, 0x00000000, 0x00000000, 0x00000000, 0, 0x1, 0x2, 0x0, 0x2, 0, 0, 0, 0);

[Noryad]

Maybe with this is enough

-- Drain Soul
UPDATE `spell_proc` SET `SpellPhaseMask` = 0x2, `AttributesMask` = 0x0 WHERE `SpellId` = -1120;

[ccrs]

@ariel- In the original commit months ago I had this working, iirc u changed something in the next weeks. Time to check commit logs xD

[ariel-]

Yeah, it is weird.. crazy spells