Trinitycore: [3.3.5] Spell/Hunter: Traps are always visible to enemies

[Noryad]

Description:
The hunter traps are always visible and should not, this makes it very easy to avoid the traps. Enemies can only see traps up to 10 yards away, in this case it is very likely that the enemy will fall into the trap. Only rogues with Detect Traps can see traps easily.

Current behaviour:
Hunter's traps are always visible.

Expected behaviour:
Enemies can only see traps 10 yards or less away.

Steps to reproduce the problem:

1. With a hunter use any trap.
2. Any enemy can see the trap from afar.

Branch(es): 3.3.5

TC rev. hash/commit: 674ac56

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

[ariel-]

I don't have this visibility problem. Are you sure you're testing with .gm off?

[Noryad]

Yes @ariel- i am sure, i tested it without gm (gmlevel = 0) and the traps still visible. I propose to use the following addon https://www.wowace.com/media/files/449/124/RangeDisplay-r311.zip to help us to solve this problem. This addon (Range Display) shows the distance between a player and his target. Now with this tool you can verify that the enemy can see all the traps of the hunter to more than 10 yards.

[ariel-]

The problem: https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Entities/GameObject/GameObject.cpp#L286

Traps are given a fixed stealth value of 70. That makes them easier to detect at levels greater than 14 (detection is 5 * level)

They should at least inherit owner level (ie 400 stealth at level 80)

[Noryad]

I tested it with this modification
m_stealth.AddValue(STEALTH_TRAP, 400);
and works ok for level 80.
Only remains to calculate that value dynamically.