Trinitycore: [3.3.5][Crash] Crash by reentering a Battleground

[Snoopzz]

when i'm in a battleground and log out and log in again two times in a row my World Server Crashs with the following error Message

TrinityCore\src\server\game\Entities\Object\Object.h:532 in Worldobject::GetMap ASSERTION FAILED: m_currMap

Branch: 3.3.5

TC hash/commit: 02d7df6

Does anyone know why this happend?
thanks for answers

[ghost]

To find out why, you need to build (cmake & compile) your source again in Debug mode.
After that, post your core revision hash + debug crash log in your first post here.

[Aokromes]

useless report, deleting template is evil.

[nawuko]

Hey!

Can confirm the crash - there are 2 ways to fixing this.
Cause: If your db mapEntry (in Player::LoadFromDB) is an Battleground "SetInviteForBattlegroundQueueType" will be executed, that one creates a group bla bla bla bla -> CheckInstanceValidity is called which calls "GetMap" -> map is not yet set for the player -> assert.

[ariel-]

bool Player::CheckInstanceValidity(bool /*isLogin*/)
{
    // game masters' instances are always valid
    if (IsGameMaster())
        return true;

    // non-instances are always valid
    Map* map = GetMap();
    if (!map || !map->IsDungeon())
        return true;
/* (...) */

GetMap() asserts if m_currMap is null, since it's then checking for a null value, wouldn't it make more sense to change the call to FindMap()? FindMap may return null and not assert, since the check is still in place, it shouldn't be a problem.

[joschiwald]

i think this needs to be applied again c7bad70e55e02fa4270f225e2dc42fd080db4abd (was "reverted" by treestons map can enter thing)

[Aokromes]

https://gist.github.com/Aokromes/4aad587afa906439863069b1270cffe6

[w5860363]

test https://github.com/TrinityCore/TrinityCore/commit/680a6f5f27e36b8a525182695924c46d55fe86f5

Can't reproduce this problem

But the application of CrossFactionBG custom Will encounter this problem Cause from Hunter