Trinitycore: [3.3.5][Hunter] Core/Spell: talent "Sniper Training" triggering while dead

[Treeston]

3.3.5 f37682b

The hunter talent Sniper Training applies a buff to the player if they stand still for 6 seconds.

The current core attempts to apply this buff even if the player is dead, leading to the player receiving a "You are dead" error message every 5 seconds while standing still as a ghost.

[Kodekc]

Same with talent http://wotlk.openwow.com/spell=48108!
With the explosion of fire bombs, proc will attempt to activate on dead aim

[P-Kito]

Is there any proc in WoW that requires to proc when being dead?
Else we could just return when target of proc is dead.

[mik1893]

i think we should just return... cant think of something that procs when you are dead

[Treeston]

I can pretty much guarantee that there is some niche spell somewhere that procs while dead, yes.

[mik1893]

of course, it's bl1z.... we never going to find it out anyway, better to break it and then fix the exception :)

[Treeston]

That is not how core development works. Find a hack-free way to fix it, then we can talk.

[Shauren]

As I said in the closed PR that attempted to fix it (https://github.com/TrinityCore/TrinityCore/pull/16857#issuecomment-216812506)

• Sniper Training is NOT A PROC. It's a periodic trigger aura.

[nawuko]

My take on this: https://gist.github.com/Nawuko/c9f489418b6b89d1fc1ecb09a29f12d7
No gurantees and line count dosent match (You have to apply manually)

Cheers.

[Treeston]

Tested, @Nawuko? Looks like a clean solution to me (curious that TRIGGERED_DONT_REPORT_CAST_ERROR isn't already checked there).

[Shauren]

Why not here https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Spell.cpp#L3791?

[Treeston]

Agree with @Shauren. We should remove all the various TRIGGERED_DONT_REPORT_CAST_ERROR checks from CheckCast and have it checked in SendCastResult instead.

[nawuko]

Yea, i try always to change little as i can when it comes to something like the spell system. Shaurens sugestion makes more sense. So go go open a PR tree <3

[Treeston]

Will do later today when I get home.

[Shauren]

Please note that you need to place it in 2 methods - SendCastResult(SpellCastResult) and SentPetCastResult(SpellCastResult), not the one taking in a large amount of arguments (its static and you dont have access to _triggeredCastFlags)

[Treeston]

Yup, I'm aware. Thanks for the heads up anyway.