Toolkit: Increased timeouts of tests on macos
Describe the bug
Our unit tests on macos have begun to timeout quite frequently. It seems to be getting bogged down when inflating tar files: https://github.com/GoogleCloudPlatform/github-actions/pull/43/checks?check_run_id=413790873
These tests only take 50-60 seconds to successfully complete on ubuntu and windows. They're timing out after 6.5 mins on macos.
Is there a resource contention/constraint issue we should be aware of with the macos runners?
To Reproduce
Steps to reproduce the behavior:
Create a test which downloads and extracts a large tar file, eg: https://dl.google.com/dl/cloudsdk/channels/rapid/downloads/google-cloud-sdk-278.0.0-darwin-x86_64.tar.gz
Notice the test timeout.
Expected behavior
The expected behavior is for the downloading and extracting of archive files on macos runners to complete with execution times similar to ubuntu and windows runners.
craigdbarber
All 2 comments
Adding to the flakiness being experienced with macos, now it appears intermittent outbound HTTP requests are coming back as 403, only on macos runners:
https://github.com/GoogleCloudPlatform/github-actions/runs/416288736?check_suite_focus=true
craigdbarber
on 30 Jan 2020
Disregard. Tracked this down to the test cleanup code timing out. Turns out deleting large temp directories is slower on macos. Extending the cleanup timeouts did the trick.
craigdbarber
on 30 Jan 2020
Related issues
JamesIves
路
5Comments
kcgen
路
6Comments
andrewdhazlett
路
5Comments
jhenstridge
路
6Comments
peternewman
路
3Comments
Most helpful comment
Disregard. Tracked this down to the test cleanup code timing out. Turns out deleting large temp directories is slower on macos. Extending the cleanup timeouts did the trick.