Toggldesktop: 24 hour clock and locale settings

[zymurgic]

I've noted this under MacOS.

in TimeEntryEditViewController, Start-end time is displaying time in 12 hour format with an AM/PM flag, regardless what the System control panel locale settings are.

So, where the user is more used to dealing with 24 hour clock, if the user needs to retrospectively go in and change the start of an time entry, notably if it's after noon, it can get rather confused if the user forgets to change the AM/PM flag too, thinking that changing the start from 12:15 to 11:45, suddenly it assumes 11:45PM the previous day.

Suggestion:
Get the start and end times to be displayed and parsed according to system locale settings.

Futher reading:
https://developer.apple.com/library/content/documentation/MacOSX/Conceptual/BPInternational/InternationalizingLocaleData/InternationalizingLocaleData.html

[IndrekV]

Toggl Desktop uses the time format that is defined in the user profile. User setting can be edited in the web app profile view.

[zymurgic]

suggestion: Make that more obvious, and possibly highlight if the locale settings on the desktop don't match what the web app profile view is using. Can be quite important around dates like the 10th of November, where the month and day are similar, and it may not be obvious which format the date is being displayed in.

[IndrekV]

Adding a help question mark near the calendar field with the proper description would make it clearer how the format is set. Thank you for pointing out this issue.

[denisw]

The user profile time format is not used for the start and end times, which is super annoying. See #2355