Tilix: Quit Terminix kills background window only

[alex285]

To reproduce

1 Open two Terminix instances, A and B

1. On Terminix A run a long run task, for example "htop"
2. On Terminix B use quit menu

Output:
Terminix display the "There are processes still running, close anyway?" dialog, but for the Terminix A, when we are on Terminix B

If we select close, it will close Terminix A, but it will leave Terminix B open.

[alex285]

Are we sure we want "Quit" to close all instances? I know that is GNOME HIG but some applications get exceptions. For example GNOME Terminal and GNOME Calculator, that "Quit" only closes current window.

[egmontkob]

FYI: A bit of gnome-terminal discussion (with no conclusion as far as I recall): https://bugzilla.gnome.org/show_bug.cgi?id=766081

[f2404]

Another FYI: In xfce4-terminal, the menu entry is called "Close Window", and it closes current window only. There's no option to close all terminal windows.

[gnunn1]

Generally I'm the camp that yes it should close all windows. Having said that, the dialog could certainly be improved such as showing a list of all windows and processes running that makes it easier for the user to decide.

So not closing all windows is the bug IMHO.

[gnunn1]

I've done an initial iteration of my design. Essentially a new dialog gets shown when you attempt to close an application, window, session or terminal if that object has any running processes in the tree. The new dialog shows the processes that are still running and let's you cancel the close.

Note I'm not 100% happy with the look of the dialog yet, right now I'm showing the titles of the objects which can be confusing depending on how things are configured. Here's a screenshot of how it looks now, design input is welcome.

[gnunn1]

I wrapped the titles in Window (..) and Session(..) and am reasonably satisfied with the result. I've closed this issue, however if someone has ideas on how to make this look better I'm happy to take the input.

[alex285]

Perfect!

[alex285]

@gnunn1 Is there any reason on the dialog to explicitly need to choose what session to close? For example by default close all. But if we select 2/3, will quit only these 2

[gnunn1]

The selection is meaningless, it either closes everything or closes nothing. If it's not doing that then there's a bug, please open an issue.