Three.js: logarithmicDepthBuffer broken on NVidia 10x series ( at least )

[olivierchatry]

Description of the problem

logarithmicDepthBuffer is broken on NVidia hardware.
Repro : On 1080 and 1070 ( only nvidia GPU I have ), launch the logarithmicDepthBuffer sample,
weird artifacts happens.

This is not happening on 108 ( so only master / 109 ).
Works on Radeon ( RX570 and Vega56 ), did not test on intel.

Three.js version

• [x] Dev
• [x] r109

Browser

• [ ] All of them
• [x] Chrome
• [x] Firefox
• [x] Internet Explorer

OS

• [ ] All of them
• [x] Windows
• [ ] macOS
• [ ] Linux
• [ ] Android
• [ ] iOS

Hardware Requirements (graphics card, VR Device, ...)

• [x] NVIDIA GPU ( only tested on 1080, and 1070, latest driver )

[Mugen87]

Do you see any warnings/errors in the browser console?

[looeee]

weird artifacts happens

Can you provide a screenshot of the artefacts?

[olivierchatry]

Nothing out of the ordinary.

On Tue, Oct 22, 2019, 4:16 PM Michael Herzog [e-mail]
wrote:

Do you see any warnings/errors in the browser console?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/17791?email_source=notifications&email_token=AAJVOG3FKXGAUEZS7BWEPILQP4DNVA5CNFSM4JDPFRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB54V5Q#issuecomment-544983798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVOG4G4MXRLNVQQ6CMB53QP4DNVANCNFSM4JDPFRMA
.

[olivierchatry]

Actually, exactly the same as :
https://github.com/mrdoob/three.js/issues/17623

On Tue, Oct 22, 2019, 4:28 PM Olivier Chatry [e-mail]
wrote:

Nothing out of the ordinary.

On Tue, Oct 22, 2019, 4:16 PM Michael Herzog [e-mail]
wrote:

Do you see any warnings/errors in the browser console?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/17791?email_source=notifications&email_token=AAJVOG3FKXGAUEZS7BWEPILQP4DNVA5CNFSM4JDPFRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB54V5Q#issuecomment-544983798,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVOG4G4MXRLNVQQ6CMB53QP4DNVANCNFSM4JDPFRMA
.

[gkjohnson]

@olivierchatry It sounds like the same issue as #17623 like you mentioned. Does this still happen on the current dev branch? I would expect #17631 to have fixed it.

[olivierchatry]

Yes it does. Cloned the repos, build it, same error. I will try again
today, just to be sure.

On Wed, Oct 23, 2019, 3:05 AM Garrett Johnson [e-mail]
wrote:

@olivierchatry https://github.com/olivierchatry It sounds like the same
issue as #17623 https://github.com/mrdoob/three.js/issues/17623 like
you mentioned. Does this still happen on the current dev branch? I would
expect #17631 https://github.com/mrdoob/three.js/pull/17631 to have
fixed it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/17791?email_source=notifications&email_token=AAJVOG22WHUR4UXGV3HOUKLQP6PPHA5CNFSM4JDPFRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB7V25I#issuecomment-545217909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVOG7QIOFIPHSJHX3TFJDQP6PPHANCNFSM4JDPFRMA
.

[gkjohnson]

I just upgraded to a 2070 and am able to reproduce the issues from #17623 with this hardware but the problem is resolved in latest dev. I tested using the "camera / logarithmicdepthbuffer" example in the repo. Just run npm start in the root of the repo and navigate to http://localhost:8080/examples/index.html?q=log#webgl_camera_logarithmicdepthbuffer.

Here's a before and after of what I see on the current three js examples website (left) and what I see when running the example locally with the latest dev branch (right):

So for me the issue is addressed in dev. If it is still broken for you do you mind posting a screenshot of what you see when running locally on dev?

[olivierchatry]

This is what I did, ( started with git checkout r108, build, tested, then
r109, then Dev ( master ). I might have done something wrong between 109
and master, I will try again as soon as I'm in the office ( I'm on ati at
home ).

On Wed, Oct 23, 2019, 7:58 AM Garrett Johnson [e-mail]
wrote:

I just upgraded to a 2070 and am able to reproduce the issues from #17623
https://github.com/mrdoob/three.js/issues/17623 with this hardware but
the problem is resolved in latest dev. I tested using the "camera /
logarithmicdepthbuffer" example in the repo. Just run npm start in the
root of the repo and navigate to
http://localhost:8080/examples/index.html?q=log#webgl_camera_logarithmicdepthbuffer
.

Here's a before and after of what I see on the current three js examples
website (left) and what I see when running the example locally with the
latest dev branch (right):

[image: image]
https://user-images.githubusercontent.com/734200/67361883-a9e9b300-f51e-11e9-90df-64b483abe8a3.png

So for me the issue is addressed in dev. If it is still broken for you do
you mind posting a screenshot of what you see when running locally on dev?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/17791?email_source=notifications&email_token=AAJVOGZTCKPKMFHFEH545N3QP7RZVA5CNFSM4JDPFRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAE6YI#issuecomment-545279841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVOGYKWCSXUU6CZ2TYKRLQP7RZVANCNFSM4JDPFRMA
.

[olivierchatry]

Also if that change anything ( but I don't think it should ), I accessed
the sample directly through
http://localhost:8080/examples/webgl_camera_logarithmicdepthbuffer.html

On Wed, Oct 23, 2019, 8:01 AM Olivier Chatry [e-mail]
wrote:

This is what I did, ( started with git checkout r108, build, tested, then
r109, then Dev ( master ). I might have done something wrong between 109
and master, I will try again as soon as I'm in the office ( I'm on ati at
home ).

On Wed, Oct 23, 2019, 7:58 AM Garrett Johnson [e-mail]
wrote:

I just upgraded to a 2070 and am able to reproduce the issues from #17623
https://github.com/mrdoob/three.js/issues/17623 with this hardware but
the problem is resolved in latest dev. I tested using the "camera /
logarithmicdepthbuffer" example in the repo. Just run npm start in the
root of the repo and navigate to
http://localhost:8080/examples/index.html?q=log#webgl_camera_logarithmicdepthbuffer
.

Here's a before and after of what I see on the current three js examples
website (left) and what I see when running the example locally with the
latest dev branch (right):

[image: image]
https://user-images.githubusercontent.com/734200/67361883-a9e9b300-f51e-11e9-90df-64b483abe8a3.png

So for me the issue is addressed in dev. If it is still broken for you do
you mind posting a screenshot of what you see when running locally on dev?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/17791?email_source=notifications&email_token=AAJVOGZTCKPKMFHFEH545N3QP7RZVA5CNFSM4JDPFRMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECAE6YI#issuecomment-545279841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJVOGYKWCSXUU6CZ2TYKRLQP7RZVANCNFSM4JDPFRMA
.

[olivierchatry]

Yup, my mistake, I was checking out master which is r109. Once I checked out dev bug disappeared. Really sorry for the mistake. Closing.