Three.js: renderTarget argument has been removed in r102

[RemusMar]

Not a single issue with the current r101.
The problem started with the current 102dev.
I get hundreds of console warnings like this one:

THREE.WebGLRenderer.render(): the renderTarget argument has been removed. Use .setRenderTarget() instead. three.min.js:197:289
THREE.WebGLRenderer.render(): the forceClear argument has been removed. Use .clear() instead. three.min.js:197:434

I get those warnings with many samples.
Here is one of them:
http://necromanthus.com/Test/html5/Lara_mirror.html

[Mugen87]

Yes, the renderTarget and the clear parameter were removed from WebGLRenderer.render(), see #15571

It's necessary to adjust your code base in order to avoid the warnings. The migration guide might be useful in this context.

[RemusMar]

Yes, the renderTarget and the clear parameter were removed from WebGLRenderer.render(), see #15571

Hi Michael,

I don't use the renderTarget and forceClear parameters in my scripts.

[Mugen87]

Can you demonstrate the warnings with a live example? It seems your linked demo still uses R101.

[RemusMar]

Can you demonstrate the warnings with a live example? It seems your linked demo still uses R101.

http://necromanthus.com/Test/html5/Lara_mirror_102dev.html

[Mugen87]

You should upgrade THREE.Mirror to THREE.Reflector. The latest version from dev should produce no warnings, see:

https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_mirror.html

[RemusMar]

You should upgrade THREE.Mirror to THREE.Reflector. The latest version from dev should produce no warnings, see
https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_mirror.html

I tried Reflector a few days ago and I got the same warnings.
But I will investigate more this evening.
cheers

[RemusMar]

As I expected, the same console warnings with Reflector and 102dev:
http://necromanthus.com/Test/html5/Lara_reflector_102dev.html

[Mugen87]

You are not using the correct version of the file. Try it with this one:

https://github.com/mrdoob/three.js/blob/dev/examples/js/objects/Reflector.js

Your version of Reflector has the following code:

renderer.render( scene, virtualCamera, renderTarget, true );

which is in dev:

renderer.setRenderTarget( renderTarget );
renderer.clear();
renderer.render( scene, virtualCamera );

[RemusMar]

Good catch!
Now I have to find out why do I get console warnings in 102dev for this one:
http://necromanthus.com/Test/html5/testA_disco.html

[RemusMar]

For the 2nd sample I get another console warning (thousand times, every frame) in 102 dev:

WebGLRenderer: .getCurrentViewport() now requires a Vector4 as an argument

OMG ...
Folks, did you really improve anything with all these changes?

[RemusMar]

That .getCurrentViewport() change was present in the LensFlare.js file only.
Anyway, the main question remains: any improvements after these changes?

[mrdoob]

Folks, did you really improve anything with all these changes?

Yes.

1. The getCurrentViewport() saves on garbage collection (no new Vector4 created in every call).
2. The renderTarget parameter removal simplifies how to know where is WebGLRenderer rendering to.

[mrdoob]

Thanks for testing new versions and letting us know what issues you find by the way. Super helpful!

[mrdoob]

Are all the issues with your tests solved?

[RemusMar]

Are all the issues with your tests solved?

Yes Ricardo.
Except LensFlare and Mirror (Reflector), I didn't find other issues so far.
:thumbsup: