Three.js: Dead Links In New Loading 3D Models Doc

[titansoftime]

https://rawgit.com/mrdoob/three.js/dev/docs/#manual/introduction/Loading-3D-models

At least for me, I am getting either:

or a completely blank page when clicking on any of the exporter links within the doc.

This is the case in both chrome and firefox.

Putting target="_blank" in the link html fixes the issue.

[Mugen87]

Putting target="_blank" in the link html fixes the issue.

Yes, external pages should open in a new tab. :+1:

[looeee]

They should also have rel="noopener" for security, although I'm not sure if this is still an issue for newer browsers.

[Mugen87]

@titansoftime Do you want to make the PR?

[titansoftime]

At work, gotta pick up kids. Possibly Saturday or Sunday sure.

[titansoftime]

Meh, did it during lunch.

14195

[titansoftime]

Updated PR.

14196

[d07RiV]

Use [link:http://www.examplesite.com link text] instead, it will get converted to an actual link during page load. Ideally all links should be converted to this format for flexibility.

Other docs/ pages that don't have any target attribute (I already have an open PR so I can't make another one):

• api/core/Clock (links to MDN at the top)
• examples/animations/CCDIKSolver (first link)
• examples/animations/MMDAnimationHelper (first link)
• examples/animations/MMDPhysics (first two links)
• examples/exporters/GLTFExporter (first two links)
• examples/exporters/PLYExporter (first link)
• examples/loaders/BabylonLoader (first two links)
• examples/loaders/GLTFLoader (first two links, and two links further down)
• examples/loaders/MMDLoader (first link)
• examples/loaders/OBJLoader (first link)
• examples/loaders/OBJLoader2 (first link)
• examples/loaders/PCDLoader (first link)
• examples/loaders/PDBLoader (first link)
• examples/loaders/PRWMLoader (first link and last link)
• examples/loaders/SVGLoader (first link)
• examples/loaders/TGALoader (first link)
• examples/renderers/CanvasRenderer (first link)

[Mugen87]

@d07RiV The usage of [link:...] is not free of bugs. If there are special characters in the link name like ` or &, the link is not resolved.

I already have an open PR so I can't make another one.

Why not? That should not be no problem with a new branch.

[d07RiV]

But the code that processes links can be fixed, which seems to be a better solution than trying to update a bunch of html files.

Branches are confusing, I'll see if I can manage it :(

[Mugen87]

But the code that processes links can be fixed, which seems to be a better solution than trying to update a bunch of html files.

That's right. I'd would be great if you can have a look.