Three.js: envMap doesnt work correctly in r91

[PerspectivesLab]

Hi there, envMap for MeshStandardMaterial renders differently in r91, it was rendering nice in r90,
it seems caused by mipmap generation in this commit
the cube map is 1024x1024 and generate texture maxMipLevel: 10 in r91, as in r90 is 8 static.
here are the screenshots @takahirox :

r90 :

r91:

the envmap renders correctly by far in r90, is this a wanted behaviour? thx

• [ ] Dev
• [ X] r91
• [ ] ...

Browser

• [x] All of them
• [ ] Chrome
• [ ] Firefox
• [ ] Internet Explorer

OS

• [x] All of them
• [ ] Windows
• [ ] macOS
• [ ] Linux
• [ ] Android
• [ ] iOS

[richardmonette]

@PerspectivesLab 's which loader are you using to load the envmap (cubemap)?

[PerspectivesLab]

i use the cubemap loader, and assign material.envMap @richardmonette
i was wondering the logic behing the formula? :
textureProperties.__maxMipLevel = Math.max( Math.log2( Math.max( image.width, image.height ) ), textureProperties.__maxMipLevel );
i was also wondering about the threshold step when the mimaps change ( because obviously the map is too blurred from a distance ), how could we control the threshold steps for the mips ?

[takahirox]

Could you make a live example for the test?

[mrdoob]

This may be unrelated, but I found this code in the wild today:

float tex_mip_level(highp vec2 coord, highp vec2 tex_size) {
   highp vec2 coord_scaled = coord * tex_size;

   highp vec2 dx_scaled = dFdx(coord_scaled);
   highp vec2 dy_scaled = dFdy(coord_scaled);

   highp vec2 dtex = dx_scaled*dx_scaled + dy_scaled*dy_scaled;
   highp float min_delta = max(dtex.x,dtex.y);
   float miplevel = max(0.5 * log2(min_delta), 0.0);

   return miplevel;
}