Theia: search-in-workspace: does not respect 'files.exclude'

[vince-fugnitto]

Description

The search-in-workspace search does not respect the globs presented in the files.exlude preference. The default preference consists of:

"files.exclude": {
  "**/.git": true,
  "**/.svn": true,
  "**/.hg": true,
  "**/CVS": true,
  "**/.DS_Store": true
}

However, when searching, I can see results from the .git folder:

Using the Include Ignored Files option has no effect as well.

[akosyakov]

@vince-fugnitto Does it in VS Code?

[vince-fugnitto]

@vince-fugnitto Does it in VS Code?

VS Code does respect the property but they have an additional preference to control the behavior, namely search.exclude which inherits values from files.exclude:

https://github.com/microsoft/vscode/blob/4c59cdd20dc90f9d6a9d4c2b11661f0a026672c1/src/vs/workbench/contrib/search/browser/search.contribution.ts#L649-L671

We should look to support such a preference as well.

[akosyakov]

ok, we should align it