Theia: (VS Code Extensions) window.withProgress isCancellable is not respected

Created on 25 Jun 2019  路  3Comments  路  Source: eclipse-theia/theia

Description

ProgressOptions.isCancellable is not respected by Theia. The "Cancel" button is always present.

https://code.visualstudio.com/api/references/vscode-api#ProgressOptions

Reproduction Steps

  • call window.withProgress setting the isCancellable ProgressOptions to false.
        const validateResponse = await vscode.window.withProgress({
            title: `Processing ${pathToBind}...`,
            location: vscode.ProgressLocation.Notification,
            cancellable: false,
        }, () => {
           // ... your callback
        });

In VS Code, the Cancel button is not shown if cancellable: false is given. In Theia, the Cancel button is always shown.

OS and Theia version:
macOS mojave, theia version next

Diagnostics:

bug help wanted notifications plug-in system vscode

Most helpful comment

Now that's service! 鉂わ笍

All 3 comments

@akosyakov, is this any way I can get this prioritized, it's been silent for 3 months

This is a pretty bad one because there is no workaround for me, and users get confused when the action they cancelled continues to run.

Now that's service! 鉂わ笍

Thanks for reporting, btw.

Was this page helpful?
0 / 5 - 0 ratings