Theia: Submenu icon

Created on 16 Jan 2020  路  4Comments  路  Source: eclipse-theia/theia

Add possibility to set an icon for a submenu. Current MenuModelRegistry.registerSubmenu only accept a label.

For example:
Screen Shot 2020-01-16 at 9 13 35 AM
I'd like the Add submenu to have a + green icon.

enhancement help wanted menus
Source
picture Hanksha

All 4 comments

@Hanksha I don't think active committers will work on it any time soon. An idea will be to add another argument to registerSubmenu, something like SubmenuOptions, which should be optional and it can have different properties in it. Feel free to work on it and send a PR.

akosyakov picture akosyakov on 16 Jan 2020

@akosyakov Alright, I will do when I get some free time.

Hanksha picture Hanksha on 16 Jan 2020
❤1

Got something working.
Screen Shot 2020-02-06 at 10 24 58 AM
Screen Shot 2020-02-06 at 10 32 57 AM

Hanksha picture Hanksha on 6 Feb 2020
👍1

Closed by https://github.com/eclipse-theia/theia/pull/7091

vince-fugnitto picture vince-fugnitto on 12 Feb 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

cekvenich picture cekvenich  路  3Comments
kittaakos picture kittaakos  路  3Comments
vince-fugnitto picture vince-fugnitto  路  3Comments
akosyakov picture akosyakov  路  3Comments
jeanlucburot picture jeanlucburot  路  3Comments