Theia: Git History open diff editor have error title

[502647092]

Description

Reproduction Steps

• open git history
• open commit
• open diff editor

OS and Theia version:
git-commit: 9105c43ab

Diagnostics:

[akosyakov]

@vince-fugnitto maybe we introduced it by https://github.com/theia-ide/theia/commit/9105c43ab0fc0b386adbf698f74356055772d9c4#diff-030d37e8ae5f19ecc3c08047f819e016R100 not sure

@502647092 is there a change that you can have a look into it?

[vince-fugnitto]

Checking out master at e8a29ca5690548b1a7fa0a646274be2c3e9b0426, I can confirm that the issue is also present.

[akosyakov]

ok, someone has to figure out what is wrong, we also changed NavigatableWidgetOpenHandler, maybe it is the reason

I can have look earlier somewhere next week, if someone can before please do

[vince-fugnitto]

ok, someone has to figure out what is wrong, we also changed NavigatableWidgetOpenHandler, maybe it is the reason

It has to do with the changes from https://github.com/theia-ide/theia/pull/5918.
Removing the call normalizePath() fixes the issue.

[akosyakov]

@a1994846931931 Would you have change to have a look at https://github.com/theia-ide/theia/issues/5956#issuecomment-522000190? It seems we missed some cases.

[a1994846931931]

@a1994846931931 Would you have change to have a look at #5956 (comment)? It seems we missed some cases.

@akosyakov Sure, I'll take a look at it soon. Maybe tomorrow morning, since it's late at night here and I happen to be on a train.

[a1994846931931]

The problem is caused by that empty path '' will be normalized as . This is also the way how Node.JS path handle it. So it isn't a problem, until we call URI.normalizePath() on URI whose scheme is not file. A PR will come soon.