Theia: [editor] [typescript] block comments not properly displayed for multiple lines

Created on 23 May 2019  路  5Comments  路  Source: eclipse-theia/theia

Description

Currently, if block-comments have multiple lines, they are rendered in the following way:


/**

Get a user's name

*/
protected getName(): string {
    return this.name;
}

I'd expect block-comments to work the same way they do in monaco and vscode and add a * for each new line:


/**
*
* Get a user's name
*
*/
protected getName(): string {
    return this.name;
}

editor help wanted textmate

Most helpful comment

@BroKun do you have an idea how to bring missing parts? Could you have a look into it?

Completing the configuration item should be fine, I will test it and give a PR.

All 5 comments

The language configuration item onEnterRules will solve this problem.

@BroKun Is it the same in VS Code? I thought our textmate grammar should be aligned with their? If it is the case maybe we should fix in the upstream first, otherwise then we can move to use VS Code completely this fix will be lost. If it is just outdated grammar then please make a PR to update it.

@akosyakov The basic part is the same as VS Code, but there are some extra features that are different from javascript/javascriptreact/typescript/typescriptreact and jsx-tag. We are missing this part.
Currently we have separate configurations for these languages, although some parts are the same.

@BroKun do you have an idea how to bring missing parts? Could you have a look into it?

@BroKun do you have an idea how to bring missing parts? Could you have a look into it?

Completing the configuration item should be fine, I will test it and give a PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dhananjayharel picture dhananjayharel  路  3Comments

kpge picture kpge  路  3Comments

akosyakov picture akosyakov  路  3Comments

cekvenich picture cekvenich  路  3Comments

kittaakos picture kittaakos  路  3Comments