Theia: [languages] TS import quick fix does not work anymore

[marechal-p]

Description

I am unable to get quick fix (code actions) to work in TypeScript.

Reproduction Steps

Illustration: Workspace setup on Gitpod.

I removed the injectable import in core/src/browser/about-dialog.ts

You should not be able to add it back using quick fix.

OS and Theia version

Ubuntu/Firefox - master as of https://github.com/theia-ide/theia/commit/09559a995efd4414cfc21bc9518d24bee4ddaa33

[vince-fugnitto]

I can confirm it is also broken for:

• Ubuntu/Chrome - master as of 09559a9
• macOS - master as of 09559a9

[akosyakov]

Which TS version?

[marechal-p]

2.9.2 and 3.1.3 according to the linked Gitpod workspace.

[akosyakov]

@marechal-p it is caused by recent changes in workspace apply edit:

One need to investigate how it happens that editor version is different without any changes.

[vince-fugnitto]

Do you know why the editor version is different without any changes @JanKoehnlein?
When checking if the versions are equal the following is false.

https://github.com/theia-ide/theia/blob/61cf13d28e5d96da71bd5b606896fe0f99efd3c7/packages/monaco/src/browser/monaco-workspace.ts#L317

It seems to be introduced from https://github.com/theia-ide/theia/pull/4553.

[JanKoehnlein]

@vince-fugnitto no idea. Looks like a bug in typescript-language-server. Needs debugging to find out where it changes the document version without any file changes happening.

[svenefftinge]

I have fixed it in typescript-language server. Now publishing and updating here.