Theia: [plug-in] Implement VS Code Built-in Commands

[vparfonov]

Built-in Commands used in VS Code Extensions widely, so for beeter support in as Theia Plugin we need to cover such command as is it possible.
List of command described here:
https://code.visualstudio.com/api/references/commands

Issues:

• [ ] vscode.executeWorkspaceSymbolProvider - Execute all workspace symbol provider.
• [x] vscode.executeDefinitionProvider - Execute all definition providers. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeDeclarationProvider - Execute all declaration provider. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeTypeDefinitionProvider - Execute all type definition providers. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeImplementationProvider - Execute all implementation providers.
• [x] vscode.executeHoverProvider - Execute all hover provider. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeDocumentHighlights - Execute document highlight provider. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeReferenceProvider - Execute reference provider.
• [ ] vscode.executeDocumentRenameProvider - Execute rename provider.
• [ ] vscode.executeSignatureHelpProvider - Execute signature help provider.
• [x] vscode.executeDocumentSymbolProvider - Execute document symbol provider. #4048
• [ ] vscode.executeCompletionItemProvider - Execute completion item provider.
• [ ] vscode.executeCodeActionProvider - Execute code action provider.
• [ ] vscode.executeCodeLensProvider - Execute CodeLens provider.
• [x] vscode.executeFormatDocumentProvider - Execute document format provider. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeFormatRangeProvider - Execute range format provider. https://github.com/eclipse-theia/theia/pull/7563
• [x] vscode.executeFormatOnTypeProvider - Execute document format provider. https://github.com/eclipse-theia/theia/pull/7563
• [ ] vscode.executeLinkProvider - Execute document link provider.
• [ ] vscode.executeDocumentColorProvider - Execute document color provider.
• [ ] vscode.executeColorPresentationProvider - Execute color presentation provider.
• [x] vscode.openFolder - Open a folder or workspace in the current window or new window depending on the newWindow argument.
• [x] [plug-in] Implement 'vscode.diff' VS Code Built-in Command #4052
• [x] vscode.open - Opens the provided resource in the editor.
• [ ] vscode.removeFromRecentlyOpened - Removes an entry with the given path from the recently opened list.
• [ ] vscode.setEditorLayout - Sets the editor layout.
• [x] cursorMove - Move cursor to a logical position in the view
• [x] editorScroll - Scroll editor in the given direction
• [x] revealLine - Reveal the given line at the given logical position
• [x] editor.unfold - Unfold the content in the editor
• [x] editor.fold - Fold the content in the editor
• [x] editor.action.showReferences - Show references at a position in a file https://github.com/theia-ide/theia/issues/4084
• [ ] moveActiveEditor - Move the active editor by tabs or groups
• [ ] vscode.executeSelectionRangeProvider
• [x] vscode.prepareCallHierarchy
• [x] vscode.provideIncomingCalls
• [x] vscode.provideOutgoingCalls
• [ ] https://github.com/eclipse-theia/theia/issues/4050#issuecomment-558633078
• [ ] https://github.com/eclipse-theia/theia/issues/4050#issuecomment-561568757
• [x] [plug-in] Implement 'vscode.previewHtml' VS Code Built-in Command #4051
• [x] explorer.newFolder (for Red Hat Didact extension)
• [x] workbench.view.explorer (for Red Hat Didact extension)
• [x] workbench.action.terminal.sendSequence (for Red Hat Didact extension)
• [x] workbench.action.terminal.kill (for Red Hat Didact extension)
• [x] copyFilePath (for Red Hat Didact extension)
• [ ] revealInExplorer - Navigate the specified resource in the Navigator. https://github.com/eclipse-theia/theia/pull/8496

[akosyakov]

vscode.executeDocumentSymbolProvider -> https://github.com/theia-ide/theia/issues/4048

[akosyakov]

Whoever will do it, please check how each command is implemented in VS Code. Sometimes it is just calling another command which can be already available via Monaco. In this case we don't need to expose any internal Monaco API or copy code from VS Code, but just use our command registry and execute the very same command.

[tsmaeder]

I guess the commands should be registered here: https://github.com/theia-ide/theia/blob/master/packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts#L35

[benoitf]

I'm not finding anymore the issue but I'm pretty sure to have read that @svenefftinge wanted to align all the names of commands to match VS Code one (I suppose all the names that are not prefixed by vscode.)

here is another list as well:
https://code.visualstudio.com/docs/getstarted/keybindings#_navigation

so I would suppose vscode. commands should go as @tsmaeder said but for the others it should either rename original name (breaking change..) or currently add the alias but in theia command contribution, not only in vscode.

[akosyakov]

I'm not finding anymore the issue but I'm pretty sure to have read that @svenefftinge wanted to align all the names of commands to match VS Code one (I suppose all the names that are not prefixed by vscode.)

please see https://github.com/theia-ide/theia/pull/4193#issuecomment-459224709

cc @svenefftinge

[akosyakov]

here is another list as well:
https://code.visualstudio.com/docs/getstarted/keybindings#_navigation

👍

maybe we keep this issue as an epic and open issues per a shortcut group to implement them separately and track progress? for the debug group: https://github.com/theia-ide/theia/issues/4204

[vinokurig]

It would be great to have next commands that are needed for the VsCode Emacs Keymap extension:

• [x] lineBreakInsert - Insert Enter
• [x] workbench.action.openRecent - Open recent command #7812
• [ ] workbench.action.splitEditorDown - Split editor horizontal
• [ ] workbench.action.splitEditorRight - Split editor vertical
• [ ] workbench.action.toggleEditorGroupLayout - Toggle split layout (vertical to horizontal)
• [ ] workbench.action.navigateEditorGroups - Focus other split editor
• [ ] workbench.action.toggleSidebarVisibility - Toggle sidebar visibility
• [ ] workbench.action.toggleZenMode - Toggle Zen mode

see https://github.com/eclipse-theia/theia/pull/6625

[vinokurig]

• [ ] editor.action.reindentselectedlines

Needed for the VsCode Vim extension see: https://github.com/eclipse-theia/theia/pull/6687

[tomer-epstein]

Is there a plan to imlement 'vscode.openFolder' soon?

• [x] vscode.openFolder - Open a folder or workspace in the current window or new window depending on the newWindow argument.

[akosyakov]

@tomer-epstein PRs are welcomed, it should not be hard to implement, there is WorkspaceService .open API which accepts an URI of a folder to open and a second options with an argument whether a window should be preserved. One has to add a new command in PluginVscodeCommandsContribution.

[tavoda]

After installing VSCode VIM plugin from https://marketplace.visualstudio.com/items?itemName=vscodevim.vim, I'm getting following error after pressing CTRL+F:

TaskQueue: Error running task. Failed to handle key=. Command with id 'editorScroll' is not registered.. for VSCode VIM extension

Is editorScroll still not implemented?

[akosyakov]

@tavoda It should be, we receive directly from Monaco editor. Do you use master? It would be worth to file a separate issue.

[akosyakov]

Let's keep this issue as a live document to track missed commands coverage. One can file individual issues as well, but please update the first comment of this issue.